New issue
Advanced search Search tips

Issue 871812 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug



Sign in to add a comment

FontFaceCacheTest.MatchCombinations is flaky, crashes

Project Member Reported by a...@chromium.org, Aug 7

Issue description

On https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/ , FontFaceCacheTest.MatchCombinations keeps crashing flakily:

[ RUN      ] FontFaceCacheTest.MatchCombinations
[ CRASHED      ]
[ RUN      ] FontFaceCacheTest.MatchCombinations
[ CRASHED      ]
[ RUN      ] FontFaceCacheTest.MatchCombinations
[ CRASHED      ]

Assigning to the first person in the log who still works on Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a90b35b4592a5df93b91264cf720d95b99275fc

commit 1a90b35b4592a5df93b91264cf720d95b99275fc
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 07 16:55:31 2018

Mark FontFaceCacheTest.MatchCombinations as flaky.

BUG=871812
TBR=rjwright@chromium.org

Change-Id: I64dc5078e3f92c18fb95b7eec1e664798bd18d26
Reviewed-on: https://chromium-review.googlesource.com/1165315
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581257}
[modify] https://crrev.com/1a90b35b4592a5df93b91264cf720d95b99275fc/third_party/blink/renderer/core/css/font_face_cache_test.cc

avi: Do you know what "FLAKY_" actually does? Does it have any effect or does it just indicate to human readers that the test is flaky?

(I've seen a number of these during my current sheriffing shift.)
FLAKY_ doesn't actually do anything anymore. I added it a few times to tests only to have them fail with that FLAKY_ added to their name. If I left it on, it should be changed to DISABLED_.
Labels: -Pri-2 OS-Windows Pri-1
Status: Assigned (was: Untriaged)
This is failing consistently on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 as well, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938565151486896496/+/steps/webkit_unit_tests/0/logs/FontFaceCacheTest.FLAKY_MatchCombinations/0 .  Stack trace:

[ RUN      ] FontFaceCacheTest.FLAKY_MatchCombinations
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	std::unique_ptr<blink::ThreadHeap,std::default_delete<blink::ThreadHeap> >::get [0x6970E84F+15]
	std::unique_ptr<blink::ThreadHeap,std::default_delete<blink::ThreadHeap> >::operator* [0x696FFEDF+15]
	blink::ThreadState::Heap [0x696FFEC2+18]
	blink::ThreadState::IsOnThreadHeap [0x69700D13+51]
	blink::MemberBase<blink::StyleRuleFontFace const ,0>::CheckPointer [0x6D138FA9+265]
	blink::MemberBase<blink::StyleRuleFontFace const ,0>::operator=<blink::StyleRuleFontFace const > [0x6D26E57F+31]
	blink::Member<blink::StyleRuleFontFace const >::operator=<blink::StyleRuleFontFace const > [0x6D26E505+37]
	WTF::HashMapTranslator<WTF::HashMapValueTraits<WTF::HashTraits<blink::Member<blink::StyleRuleFontFace const > >,WTF::HashTraits<blink::Member<blink::FontFace> > >,WTF::MemberHash<blink::StyleRuleFontFace const >,blink::HeapAllocator>::Translate<WTF::KeyVa [0x6D26E451+49]
	WTF::HashTable<blink::Member<blink::StyleRuleFontFace const >,WTF::KeyValuePair<blink::Member<blink::StyleRuleFontFace const >,blink::Member<blink::FontFace> >,WTF::KeyValuePairKeyExtractor,WTF::MemberHash<blink::StyleRuleFontFace const >,WTF::HashMapValu [0x6D26E295+1013]
	WTF::HashMap<blink::Member<blink::StyleRuleFontFace const >,blink::Member<blink::FontFace>,WTF::MemberHash<blink::StyleRuleFontFace const >,WTF::HashTraits<blink::Member<blink::StyleRuleFontFace const > >,WTF::HashTraits<blink::Member<blink::FontFace> >,b [0x6D26DE6B+91]
	WTF::HashMap<blink::Member<blink::StyleRuleFontFace const >,blink::Member<blink::FontFace>,WTF::MemberHash<blink::StyleRuleFontFace const >,WTF::HashTraits<blink::Member<blink::StyleRuleFontFace const > >,WTF::HashTraits<blink::Member<blink::FontFace> >,b [0x6D26AF3B+91]
	blink::FontFaceCache::Add [0x6D26AE82+82]
	blink::FontFaceCacheTest::AppendTestFaceForCapabilities [0x01920AC5+725]
	blink::FontFaceCacheTest_FLAKY_MatchCombinations_Test::TestBody [0x01923231+1729]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0057ED3B+107]
	testing::Test::Run [0x0057EC78+184]
	testing::TestInfo::Run [0x0057F78B+251]
	testing::TestCase::Run [0x0058036D+269]
	testing::internal::UnitTestImpl::RunAllTests [0x0058904B+715]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00588D50+112]
	testing::UnitTest::Run [0x00588B99+297]
	RUN_ALL_TESTS [0x0341E3FF+15]
	base::TestSuite::Run [0x0341D99E+142]
	base::Bind<int (__cdecl*)(base::TestSuite *),base::internal::UnretainedWrapper<base::TestSuite> > [0x003A576D+205]
	base::internal::FunctorTraits<int (__cdecl*)(base::TestSuite *),void>::Invoke<int (__cdecl*const &)(base::TestSuite *),base::TestSuite *> [0x003A68E7+55]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__cdecl*const &)(base::TestSuite *),base::TestSuite *> [0x003A681A+58]
	base::internal::Invoker<base::internal::BindState<int (__cdecl*)(base::TestSuite *),base::internal::UnretainedWrapper<base::TestSuite> >,int __cdecl(void)>::RunImpl<int (__cdecl*const &)(base::TestSuite *),std::tuple<base::internal::UnretainedWrapper<base [0x003A67C5+85]
	base::internal::Invoker<base::internal::BindState<int (__cdecl*)(base::TestSuite *),base::internal::UnretainedWrapper<base::TestSuite> >,int __cdecl(void)>::Run [0x003A666F+63]
	base::OnceCallback<int __cdecl(void)>::Run [0x034253F1+81]
	base::LaunchUnitTests [0x034235C9+745]
	base::LaunchUnitTests [0x034233C8+232]
	main [0x003A566A+202]
	invoke_main [0x03B80A2E+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78)
	__scrt_common_main_seh [0x03B80B91+337] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	__scrt_common_main [0x03B80C5D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
	mainCRTStartup [0x03B80C68+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x76BB336A+18]
	RtlInitializeExceptionChain [0x777C9902+99]
	RtlInitializeExceptionChain [0x777C98D5+54]

Disabling the test.
Components: Blink>Fonts
Status: Untriaged (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b6a32c22de15bea00ed58fa55fdeafdb91767f6

commit 1b6a32c22de15bea00ed58fa55fdeafdb91767f6
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Aug 10 22:43:55 2018

Disable failing test (FLAKY_ has no meaning)

Bug: 871812
Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
TBR: mgiuca
Reviewed-on: https://chromium-review.googlesource.com/1171681
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582366}
[modify] https://crrev.com/1b6a32c22de15bea00ed58fa55fdeafdb91767f6/third_party/blink/renderer/core/css/font_face_cache_test.cc

Labels: -Pri-1 Pri-2
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment