New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871811 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

gn dependency issues in chrome/browser/vr

Project Member Reported by acondor@chromium.org, Aug 7

Issue description

1. Edit src/.gn, add "//chrome/browser/vr/*" in check_targets.
2. Run "gn check"

There are several issues, most probably originated with the ui-common split up. I tried to fixed it quickly, but soon reached some circular dependencies between common and ui.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda89e62f9e9678eb50c877f7a833b3e5dd946ef

commit cda89e62f9e9678eb50c877f7a833b3e5dd946ef
Author: Ian Vollick <vollick@chromium.org>
Date: Tue Aug 14 17:14:32 2018

[vr] fix gn check errors in chrome/browser/vr/*

There were a number of circular and incorrect dependencies between
targets in this directory. With this change, I've largely fixed the
issues by moving things to vr_base. I did, however, move ButtonState
from UiInputManager to PlatformController.

I've also removed vr_base_export.h, which turned out to be
unnecessary.

Bug:  871811 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7ee1d5c410c4098c6284dba8a3f565e6b460f34a
Reviewed-on: https://chromium-review.googlesource.com/1171667
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582953}
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/.gn
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/android/vr/gvr_controller_delegate.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/assets_loader.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/content_input_delegate.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/controller_delegate_for_testing.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ganesh_surface_provider.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/input_event.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/keyboard_ui_interface.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/metrics/metrics_helper.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/metrics/session_metrics_helper.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/assets.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/camera_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/hosted_platform_ui.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/platform_toast.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/reticle_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/sounds.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/speech_recognition_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/tab_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/toolbar_state.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/platform_controller.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/pose_util.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/render_info.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/test/ui_pixel_test.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/testapp/BUILD.gn
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/text_edit_action.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_initial_state.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_pixeltest.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_support.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/ui_test_input.h
[delete] https://crrev.com/efbda17c5637050784fbf80f8b35e2d0c11364ce/chrome/browser/vr/vr_base_export.h
[modify] https://crrev.com/cda89e62f9e9678eb50c877f7a833b3e5dd946ef/chrome/browser/vr/vr_geometry_util.h

Status: Fixed (was: Assigned)
Cc: cjgrant@chromium.org tiborg@chromium.org waff...@chromium.org
 Issue 873170  has been merged into this issue.

Sign in to add a comment