New issue
Advanced search Search tips

Issue 871810 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WebRtcEventLogManagerTestPolicy.StartsDisabledThenEnabledAllowsRemoteLogging2



Sign in to add a comment

WebRtcEventLogManagerTestPolicy.StartsDisabledThenEnabledAllowsRemoteLogging2 is Flaky

Project Member Reported by Findit, Aug 7

Issue description

Labels: -Sheriff-Chromium
Owner: eladalon@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807eaf18b27f1794bacab90e0824f75cfb364ebf

commit 807eaf18b27f1794bacab90e0824f75cfb364ebf
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 07 16:28:38 2018

Revert "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy"

This reverts commit 7dae0f6307b6ffc38b69faa9340d2ef7d298aabd.

Reason for revert: As per the Findit comment, this introduced flakiness.

Original change's description:
> Support dynamic refresh of WebRtcEventLogCollectionAllowed policy
> 
> Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed:
> 1. If the policy was disabled before, and becomes enabled,
>    subsequent calls to StartRemoteLogging() will succeed (barring
>    unrelated issues), even for peer connections created while the
>    policy was disabled.
> 2. If the policy was enabled before, and becomes disabled:
>    a. Peer connections associated with the profile reject
>       calls to StartRemoteLogging().
>    b. Active logs (associated with the profile) are stopped,
>       and those log files deleted.
>    c. Pending log files (associated with the profile) are deleted.
>    d. If a log file associated with the relevant profile is
>       currently being uploaded, the upload will be cancelled,
>       and the file deleted.
> 
> Bug: 775415
> Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f
> Reviewed-on: https://chromium-review.googlesource.com/1162168
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Elad Alon <eladalon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581167}

TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org

Change-Id: Ia8d317dbd6d058d94255554c05d3d0393045af75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775415,  871809 , 871810
Reviewed-on: https://chromium-review.googlesource.com/1165602
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581248}
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/components/policy/resources/policy_templates.json
[modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/content/public/browser/webrtc_event_logger.h

Sign in to add a comment