Findit has detected flake occurrences for the test WebRtcEventLogManagerTestPolicy.StartsDisabledThenEnabledAllowsRemoteLogging2 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I70a02ff04eded2926e56fa8e368715ec1ff7c34f Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKjAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ4MzkzL3VuaXRfdGVzdHMvVjJWaVVuUmpSWFpsYm5STWIyZE5ZVzVoWjJWeVZHVnpkRkJ2YkdsamVTNVRkR0Z5ZEhORWFYTmhZbXhsWkZSb1pXNUZibUZpYkdWa1FXeHNiM2R6VW1WdGIzUmxURzluWjJsdVp6ST0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRtcEventLogManagerTestPolicy.StartsDisabledThenEnabledAllowsRemoteLogging2&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKjAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ4MzkzL3VuaXRfdGVzdHMvVjJWaVVuUmpSWFpsYm5STWIyZE5ZVzVoWjJWeVZHVnpkRkJ2YkdsamVTNVRkR0Z5ZEhORWFYTmhZbXhsWkZSb1pXNUZibUZpYkdWa1FXeHNiM2R6VW1WdGIzUmxURzluWjJsdVp6ST0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
Findit identified the culprit r581167 with confidence 100.0% in the config "tryserver.chromium.linux / linux_chromium_asan_rel_ng" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKjAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ4MzkzL3VuaXRfdGVzdHMvVjJWaVVuUmpSWFpsYm5STWIyZE5ZVzVoWjJWeVZHVnpkRkJ2YkdsamVTNVRkR0Z5ZEhORWFYTmhZbXhsWkZSb1pXNUZibUZpYkdWa1FXeHNiM2R6VW1WdGIzUmxURzluWjJsdVp6ST0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRtcEventLogManagerTestPolicy.StartsDisabledThenEnabledAllowsRemoteLogging2&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKjAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzQ4MzkzL3VuaXRfdGVzdHMvVjJWaVVuUmpSWFpsYm5STWIyZE5ZVzVoWjJWeVZHVnpkRkJ2YkdsamVTNVRkR0Z5ZEhORWFYTmhZbXhsWkZSb1pXNUZibUZpYkdWa1FXeHNiM2R6VW1WdGIzUmxURzluWjJsdVp6ST0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/807eaf18b27f1794bacab90e0824f75cfb364ebf commit 807eaf18b27f1794bacab90e0824f75cfb364ebf Author: Avi Drissman <avi@chromium.org> Date: Tue Aug 07 16:28:38 2018 Revert "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy" This reverts commit 7dae0f6307b6ffc38b69faa9340d2ef7d298aabd. Reason for revert: As per the Findit comment, this introduced flakiness. Original change's description: > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > 1. If the policy was disabled before, and becomes enabled, > subsequent calls to StartRemoteLogging() will succeed (barring > unrelated issues), even for peer connections created while the > policy was disabled. > 2. If the policy was enabled before, and becomes disabled: > a. Peer connections associated with the profile reject > calls to StartRemoteLogging(). > b. Active logs (associated with the profile) are stopped, > and those log files deleted. > c. Pending log files (associated with the profile) are deleted. > d. If a log file associated with the relevant profile is > currently being uploaded, the upload will be cancelled, > and the file deleted. > > Bug: 775415 > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > Reviewed-on: https://chromium-review.googlesource.com/1162168 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elad Alon <eladalon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581167} TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org Change-Id: Ia8d317dbd6d058d94255554c05d3d0393045af75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415, 871809 , 871810 Reviewed-on: https://chromium-review.googlesource.com/1165602 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581248} [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager.cc [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager.h [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/components/policy/resources/policy_templates.json [modify] https://crrev.com/807eaf18b27f1794bacab90e0824f75cfb364ebf/content/public/browser/webrtc_event_logger.h
Comment 1 by Findit
, Aug 7