[Mac] Add field power metrics |
||
Issue descriptionIt's technically possible to collect system power usage on Mac, and Chrome should do so.
,
Aug 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b45324f9d4b2453dbfd79a511e2aa1ed9681391 commit 4b45324f9d4b2453dbfd79a511e2aa1ed9681391 Author: Sidney San Martín <sdy@chromium.org> Date: Sat Aug 18 01:57:42 2018 [Mac] Fix wrong metric names. In 3bd1f5ed9cf7e4dadae9f765d57c4d256790bab1, I renamed the histograms right before commit, and I forgot to rename them in some places. Whoops. TBR=rkaplow Bug: 871801 Change-Id: Iff576c3d9c06878b4f2f60c6fb6557b16e915d1c Reviewed-on: https://chromium-review.googlesource.com/1180293 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584282} [modify] https://crrev.com/4b45324f9d4b2453dbfd79a511e2aa1ed9681391/chrome/browser/metrics/power_metrics_provider_mac.mm [modify] https://crrev.com/4b45324f9d4b2453dbfd79a511e2aa1ed9681391/tools/metrics/histograms/histograms.xml
,
Aug 28
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/943d3f6eaeaea6b614c7cce17b3b3335104bfbc1 commit 943d3f6eaeaea6b614c7cce17b3b3335104bfbc1 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Aug 29 02:08:56 2018 [Mac] Skip logging a power metric if its value is zero. Some machines have certain SMC sensor keys but don't return a value from them. This change stops that from affecting stats. Also refactor a bit to avoid adding repetition. Bug: 871801 Change-Id: Ib7e50cc36b3ba3a3a5be180db66334e45a99131d Reviewed-on: https://chromium-review.googlesource.com/1194496 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586998} [modify] https://crrev.com/943d3f6eaeaea6b614c7cce17b3b3335104bfbc1/chrome/browser/metrics/power_metrics_provider_mac.mm
,
Dec 9
Is this fixed? |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 15