New issue
Advanced search Search tips

Issue 871799 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

GLHelperPixelReadbackTest.ScalePatching flaky

Project Member Reported by a...@chromium.org, Aug 7

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 has viz_unittests fail a lot due to flakiness of GLHelperPixelReadbackTest.ScalePatching
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2916491eaf8281a9464e0b14c2e9d1ad6842c023

commit 2916491eaf8281a9464e0b14c2e9d1ad6842c023
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 07 16:28:17 2018

Mark ScalePatching as flaky.

BUG= 871799 
TBR=miu@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I63e3694a2f006daab624cf434da682dbd725f789
Reviewed-on: https://chromium-review.googlesource.com/1165313
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581247}
[modify] https://crrev.com/2916491eaf8281a9464e0b14c2e9d1ad6842c023/components/viz/common/gl_helper_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1284a62de05c781f88de8b4d1a47e3112826e5

commit 4d1284a62de05c781f88de8b4d1a47e3112826e5
Author: Fredrik Hubinette <hubbe@google.com>
Date: Wed Aug 08 00:19:58 2018

Disable GLHelperPixelReadbackTest.ScalePatching

This test does too much and is flaky on some platforms.

TBR=miu@chromium.org

Bug:  871799 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If937a1736fcfdca4f004a8f4cf0660bac5f1f794
Reviewed-on: https://chromium-review.googlesource.com/1166283
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581410}
[modify] https://crrev.com/4d1284a62de05c781f88de8b4d1a47e3112826e5/components/viz/common/gl_helper_unittest.cc

Components: Internals>Media>ScreenCapture
Well, that's odd. It's only been flaky since 5 August (two days).

Looks like the tests fail due to timeout on the slow Win7dbg bot. So, yeah, I suppose they should be broken-up into smaller ones.
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
Legacy GLHelper code is deprecated, being removed. See bug 870036.

Sign in to add a comment