New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871792 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

chrome.metricsPrivate API not whitelisted for chromevox on cast

Project Member Reported by rmrossi@chromium.org, Aug 7

Issue description

chrome.metricsPrivate API is not accessible to chromevox background script when installed on cast.  The extension id (which is different from the web store chromevox version) is missing from the whitelist.

This caused an extension warning and subsequent failure when the background page attempted to access chrome.metricsPrivate.*

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ec6e693905b78ca55ffff78562c66f56eac21b

commit c4ec6e693905b78ca55ffff78562c66f56eac21b
Author: Randy Rossi <rmrossi@chromium.org>
Date: Tue Aug 07 16:52:11 2018

Add chromevox to metricsPrivate whitelist

Chromevox on chromecast was failing on providing
chrome.metricsPrivate API due to its id hash
not being in the whitelist.  This halted processing
of swipe gestures.  Added hash to whitelist.

Bug: 871792
Test: Manual

Change-Id: Ic37100b70e3ca32890b88c8de0470f26ee93864b
Reviewed-on: https://chromium-review.googlesource.com/1155162
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581256}
[modify] https://crrev.com/c4ec6e693905b78ca55ffff78562c66f56eac21b/extensions/common/api/_permission_features.json

I don't understand this change. The root cause is ChromeVox is a component extension. THis will bite in other ways as ChromeVox starts using other private apis. One such api is settingsPrivate, which ChromeVox now uses to control tts speech rate, pitch, and volume. We also now utilize system prefs for the current user profile to store those speech values.
Status: Assigned (was: Untriaged)
Another thought: is there any reason that ChromeVox on Cast couldn't just use the same extension ID?

Sign in to add a comment