Anroid OOP-D: PollInstrumentation problems |
||||
Issue descriptionA large number of chrome_public_test_apk tests are failing with callstacks that end up in: org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread These largely come from: org.chromium.chrome.test.util.browser.TabLoadObserver.assertLoaded But occasionally come from: org.chromium.chrome.browser.FullscreenActivityTest.enterFullscreen Guessing this is a basic issue with our instrumentation hookups on Android w/ Viz.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/becbb3c96493c0790aa5cd493375e47a61f030e8 commit becbb3c96493c0790aa5cd493375e47a61f030e8 Author: Eric Karl <ericrk@chromium.org> Date: Wed Aug 15 20:18:32 2018 Android OOP-D: Fix content_shell_test_apk Fixes two issues which were leading to failures in content_shell_test_apk: 1) We weren't correctly linking in the Android external begin frame source java code into content shell, leading to crashes due to class resolution failure. 2) Scroll tests assume that the browser is notified of every scroll offset change, whether or not it impacts the UI. As an optimization, SurfaceSync/Viz doesn't send this data unless needed. Adds a test only hook to always send data allowing for test inspeciton. Note that this addresses all but one remaining failure in: org.chromium.content.browser.VSyncPausedTest#testPauseVSync Bug: 871774 , 871772 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I031d6616bcef11d302b6ecd43ee75586fbae8d71 Reviewed-on: https://chromium-review.googlesource.com/1173736 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583372} [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/browser/BUILD.gn [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/browser/web_contents/web_contents_android.h [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/BUILD.gn [add] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java [add] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/web_contents_utils.cc [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/shell/android/BUILD.gn [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellActivityTestRule.java
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a commit 4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a Author: Eric Karl <ericrk@chromium.org> Date: Thu Aug 16 02:26:56 2018 Android OOP-D: Forward VSync pause requests to Viz proc Currently VR pauses/unpuases VSync during certain transitions. These calls work when the Browser's AndroidWindow is the VSync provider, but not when using a remote GPU proc VSync provider. Forward these signals to the GPU process. TBR=yfriedman for really uninteresting test-code update. Bug: 871774 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic47cb14fdf702e294db90b5ad69b8cdfb5c67403 Reviewed-on: https://chromium-review.googlesource.com/1175198 Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583505} [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/components/viz/service/frame_sinks/root_compositor_frame_sink_impl.h [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/content/browser/android/overscroll_controller_android_unittest.cc [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/content/browser/renderer_host/compositor_impl_android.cc [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/content/browser/renderer_host/compositor_impl_android.h [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/services/viz/privileged/interfaces/compositing/display_private.mojom [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/ui/android/delegated_frame_host_android_unittest.cc [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/ui/android/window_android.cc [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/ui/android/window_android.h [modify] https://crrev.com/4ce5757e6d770cc50f92bc8c37a23acf4fb4c01a/ui/android/window_android_compositor.h
,
Aug 16
,
Aug 16
Still a few more cases to track down.
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec26a37e0d1bdf0a6a557980f1c734b44148a470 commit ec26a37e0d1bdf0a6a557980f1c734b44148a470 Author: Eric Karl <ericrk@chromium.org> Date: Tue Aug 21 03:36:07 2018 Android OOP-D: Populate |current_surface_size_| via RenderFrameMetadata We currently populate a |current_surface_size_| variable in Render... WidgetHostViewAndroid via frame sizes in SubmitCompositorFrame. In Viz mode we don't get SubmitCompositorFrames, so we miss these udpates. This variable is used for fullscreen transition improvements and general frame-readiness checks. This value is present in RenderFrameMetadata, and can be populated from there in the Viz case. Bug: 871774 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6892cbb35590e03e2b8a7d2d822a7b29308f7439 Reviewed-on: https://chromium-review.googlesource.com/1180517 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584635} [modify] https://crrev.com/ec26a37e0d1bdf0a6a557980f1c734b44148a470/cc/trees/render_frame_metadata.h [modify] https://crrev.com/ec26a37e0d1bdf0a6a557980f1c734b44148a470/content/browser/renderer_host/render_widget_host_view_android.cc
,
Aug 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ericrk@chromium.org
, Aug 14Status: Started (was: Available)