Android Surface Synchronization: testPeekWithPageScrollPercentage failure |
|||||
Issue descriptionWhile other tests fail due to OOP-D, this is the one chrome_public_test_apk case which fails with just Surface Synchronization. We appear to be failing to receive the second scroll gesture we expect: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java?rcl=2e57b3196d01b1d59e626881dde75256daecc3d9&l=654 I wonder if our simulated gestures are using the wrong unit conversion, leading to the second scroll being a no-op?
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/becbb3c96493c0790aa5cd493375e47a61f030e8 commit becbb3c96493c0790aa5cd493375e47a61f030e8 Author: Eric Karl <ericrk@chromium.org> Date: Wed Aug 15 20:18:32 2018 Android OOP-D: Fix content_shell_test_apk Fixes two issues which were leading to failures in content_shell_test_apk: 1) We weren't correctly linking in the Android external begin frame source java code into content shell, leading to crashes due to class resolution failure. 2) Scroll tests assume that the browser is notified of every scroll offset change, whether or not it impacts the UI. As an optimization, SurfaceSync/Viz doesn't send this data unless needed. Adds a test only hook to always send data allowing for test inspeciton. Note that this addresses all but one remaining failure in: org.chromium.content.browser.VSyncPausedTest#testPauseVSync Bug: 871774 , 871772 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I031d6616bcef11d302b6ecd43ee75586fbae8d71 Reviewed-on: https://chromium-review.googlesource.com/1173736 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583372} [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/browser/BUILD.gn [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/browser/web_contents/web_contents_android.h [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/android/javatests/src/org/chromium/content/browser/ContentViewScrollingTest.java [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/BUILD.gn [add] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java [add] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/public/test/android/web_contents_utils.cc [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/shell/android/BUILD.gn [modify] https://crrev.com/becbb3c96493c0790aa5cd493375e47a61f030e8/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellActivityTestRule.java
,
Aug 15
,
Aug 20
I had confused this failure with another test. This is still failing and the CL above doesn't address things. It appears that this second scroll gesture should be causing a change in our top/bottom controls, but isn't doing so. If I force all RenderFrameMetadatas to be delivered (even with no browser UI visible change), we fail the next check, as we aren't showing the "bottom sheet", see assert here: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java?rcl=2e57b3196d01b1d59e626881dde75256daecc3d9&l=659 Fady, can you take a look?
,
Aug 20
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d458b26825f8910e306cae1dc6e5c4f83da8839 commit 7d458b26825f8910e306cae1dc6e5c4f83da8839 Author: Eric Karl <ericrk@chromium.org> Date: Thu Aug 23 17:25:51 2018 Disable testPeekWithPageScrollPercentage from ContextualSuggestionTest The SurfaceSynchronization feature breaks this test, but after discussion it turns out this test is verifying behavior that is no longer used (or planned to be used in the near future). Disabling the test for now and filing a bug so we can discuss ways to work around this if we want to re-enable in the future. R=twellington@chromium.org Bug: 876943 , 871772 Change-Id: I4949b17b20e6376b9b659d9af6cb5d727f348f51 Reviewed-on: https://chromium-review.googlesource.com/1186111 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585531} [modify] https://crrev.com/7d458b26825f8910e306cae1dc6e5c4f83da8839/chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
,
Aug 23
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ericrk@chromium.org
, Aug 7