New issue
Advanced search Search tips

Issue 871770 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

TracingControllerTest fails on Mac ASAN

Project Member Reported by a...@chromium.org, Aug 7

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/42666

TracingControllerTest.EnableAndStopTracingWithEmptyFile
TracingControllerTest.GetCategories
TracingControllerTest.DoubleStopTracing
TracingControllerTest.EnableAndStopTracingWithCompression
TracingControllerTest.DisableRecordingStoresMetadata
TracingControllerTest.EnableAndStopTracingWithFilePath
TracingControllerTest.EnableAndStopTracing

BrowserTestBase received signal: Terminated: 15. Backtrace:
0   content_browsertests                0x00000001169fe7ac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   content_browsertests                0x0000000115852405 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 517
2   libsystem_platform.dylib            0x00007fff789e4f5a _sigtramp + 26
3   content_browsertests                0x0000000116947d6c base::ThreadCheckerImpl::CalledOnValidThread() const + 540

 
Cc: a...@chromium.org dtapu...@chromium.org
Owner: robliao@chromium.org
Rob, do you know who might know how to figure this out?
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebcefcc1bcc43b9285c71243fb328b67a80eb290

commit ebcefcc1bcc43b9285c71243fb328b67a80eb290
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 07 15:37:27 2018

Disable failing tests.

BUG=871770
TBR=dpranke@chromium.org, dtapuska@chromium.org

Change-Id: Ic932556cf259163af7928a00338a58fcefe104c9
Reviewed-on: https://chromium-review.googlesource.com/1165305
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581233}
[modify] https://crrev.com/ebcefcc1bcc43b9285c71243fb328b67a80eb290/content/browser/tracing/tracing_controller_browsertest.cc

Owner: primiano@chromium.org
Routing to a tracing owner for assistance in diagnosing the issue here.
Cc: oysteine@chromium.org
Owner: ----
Cc: -oysteine@chromium.org primiano@chromium.org
Owner: oysteine@chromium.org
Cc: alex...@chromium.org creis@chromium.org
alexmos/creis: Looks like this got introduced by https://chromium-review.googlesource.com/1157530

From what I can tell, what's happening is that a renderer process which normally gets started then shut down during test startup, after that CL sometimes just hangs and never executes the BeginTracing Mojo IPC we send to it, nor does it disconnect (AgentRegistry::UnregisterAgent in /services/tracing/agent_registry.cc never gets called), meaning the tracing controller never runs the StartTracingCallback in Coordinator::OnTracingStarted and the tests time out. Is this a known issue?

This reproes for TracingControllerTest.EnableAndStopTracingWithCompression (once every few runs) but I've only been able to trigger it on Mac ASAN builds for some reason (timing issue?).


#8: Looks like a different issue to this bug, got a fix up at https://chromium-review.googlesource.com/c/chromium/src/+/1232414 though
Reading comment 7, I'm pretty sure this is also related to:
  https://bugs.chromium.org/p/chromium/issues/detail?id=911839
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/193cdaa184451987cd55193a89576c5ca5c4c0f6

commit 193cdaa184451987cd55193a89576c5ca5c4c0f6
Author: Etienne Bergeron <etienneb@chromium.org>
Date: Wed Dec 05 19:37:23 2018

Re-activate a unittest disabled on ASAN build

Following up of:
  https://chromium-review.googlesource.com/c/chromium/src/+/1349495

R=oysteine@chromium.org

Bug: 871770
Change-Id: I7a3672185c8fc104cadd17248c3ca943c005fc37
Reviewed-on: https://chromium-review.googlesource.com/c/1361829
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614063}
[modify] https://crrev.com/193cdaa184451987cd55193a89576c5ca5c4c0f6/content/browser/tracing/tracing_controller_browsertest.cc

Sign in to add a comment