New issue
Advanced search Search tips

Issue 871769 link

Starred by 2 users
Status: Verified
Owner:
thegreenfrog@chromium.org
Closed: Aug 7
Cc:
sczs@chromium.org
rohitrao@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: ----
Q2



Sign in to add a comment

Clear Browsing Data crashes when invoked via TabGrid

Project Member Reported by rohitrao@chromium.org, Aug 7 
1) Open TabGrid and switch to Recent Tabs.
2) Tap on "Show Full History"
3) Tap the "Clear Browsing Data" button at the bottom left.

App crashes because the TabGrid isn't forwarding commands to the proper dispatcher.

Comment 1 by srikanthg@chromium.org, Aug 7 

thegreenfrog@ can you add a link to the CL which fixed this issue.
Also while reproducing this crash there is no crash id generated in chrome://crashes. Is this expected?

Comment 2 by thegreenfrog@chromium.org, Aug 7 

Here's the CL. https://chromium-review.googlesource.com/c/chromium/src/+/1162279

I also verified it on canary on 8/6.

Comment 3 by thegreenfrog@chromium.org, Aug 7

Labels: Merge-Request-69

Comment 4 by kariahda@chromium.org, Aug 7

Labels: -Merge-Request-69 Merge-Approved-69
Approved.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a33b659a69e52faf9c02da0f4e581e01a56e307

commit 5a33b659a69e52faf9c02da0f4e581e01a56e307
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Tue Aug 07 15:52:58 2018

[ios] Ensure TabGrid coordinator forwards BrowsingDataCommands

ApplicationCommands conforms to BrowsingDataCommands, but we need to explicitly dispatch them still.

Bug:  871769 
Change-Id: I02dbf849677c7391a6a123917f7773d2330be003
Reviewed-on: https://chromium-review.googlesource.com/1162279
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580617}(cherry picked from commit dd54970abf7776a1f1df4b113a253f65c4a9e9c2)
Reviewed-on: https://chromium-review.googlesource.com/1165502
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#466}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5a33b659a69e52faf9c02da0f4e581e01a56e307/ios/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Comment 6 by shbarezer@chromium.org, Aug 8

Status: Verified (was: Fixed)
Verified in 69.0.3497.31 Beta,  iPhone X iOS 11.4.1, iPhone 6 iOS 10.3.3
Looks good

Comment 7 by thegreenfrog@chromium.org, Aug 21 

Issue 875914 has been merged into this issue.
►

Sign in to add a comment