New issue
Advanced search Search tips

Issue 871746 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update docs/speed/perf_lab_platforms.md

Project Member Reported by perezju@chromium.org, Aug 7

Issue description

Context:
https://chromium.googlesource.com/chromium/src/+/master/docs/speed/perf_lab_platforms.md

And make it easy to update from the perf bot configurations themselves.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9

commit 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 09 15:07:32 2018

Add perf/core/bot_platforms.py file that contain metadata about all perf builders

Bug:871746,863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
Reviewed-on: https://chromium-review.googlesource.com/1169127
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[add] https://crrev.com/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9/tools/perf/core/perf_json_config_validator.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a55613fbaa32bcef500fedb60c8555bcf70877c9

commit a55613fbaa32bcef500fedb60c8555bcf70877c9
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 19:14:30 2018

Revert "Add perf/core/bot_platforms.py file that contain metadata about all perf builders"

This reverts commit 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9.

Reason for revert: Due to Gerrit outage  http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.

Original change's description:
> Add perf/core/bot_platforms.py file that contain metadata about all perf builders
> 
> Bug:871746,863768
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
> Reviewed-on: https://chromium-review.googlesource.com/1169127
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>

TBR=perezju@chromium.org,nednguyen@google.com

Change-Id: Ibbd2a2d28f9ba36967ce03fe2fa1c3331844cd18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  871746 , 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1169790
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/052af253a58d9855eb88907243e053b80951afcd/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/a55613fbaa32bcef500fedb60c8555bcf70877c9/tools/perf/core/perf_json_config_validator.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa

commit d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 09 21:34:46 2018

Reland "Add perf/core/bot_platforms.py file that contain metadata about all perf builders"

This is a reland of 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9

Original change's description:
> Add perf/core/bot_platforms.py file that contain metadata about all perf builders
>
> Bug:871746,863768
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
> Reviewed-on: https://chromium-review.googlesource.com/1169127
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>

Bug:  871746 , 863768
Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi

TBR=perezju@chromium.org

Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Reviewed-on: https://chromium-review.googlesource.com/1169882
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581900}
[add] https://crrev.com/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa/tools/perf/core/perf_json_config_validator.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9673eaffdfd307b49d3a3beabb39f042b2efe455

commit 9673eaffdfd307b49d3a3beabb39f042b2efe455
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Wed Aug 15 14:41:02 2018

[tools/perf] Update platforms in docs/speed on perf config changes

Add function on perf_data_generator to keep the list of active platform
configurations in //docs/speed/perf_lab_platforms.md up to date.

Bug:  871746 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I8d95651ad0480f7eb21b8aa6c95af5b75d37da94
Reviewed-on: https://chromium-review.googlesource.com/1166919
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#583244}
[modify] https://crrev.com/9673eaffdfd307b49d3a3beabb39f042b2efe455/docs/speed/perf_lab_platforms.md
[modify] https://crrev.com/9673eaffdfd307b49d3a3beabb39f042b2efe455/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/9673eaffdfd307b49d3a3beabb39f042b2efe455/tools/perf/core/perf_data_generator.py

Status: Fixed (was: Assigned)

Sign in to add a comment