Mac10.12 Tests fails Touchbar browser tests |
|||||
Issue descriptionFailing: TextSuggestionsTouchBarControllerTest.MakeTouchBar TextSuggestionsTouchBarControllerTest.UpdateTextSelection See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14815
,
Aug 7
[ RUN ] TextSuggestionsTouchBarControllerTest.MakeTouchBar [93891:4611:0807/055713.482373:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated. 2018-08-07 05:57:13.650 browser_tests[93891:1414818] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug. ../../chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm:119: Failure Value of: touch_bar Actual: false Expected: true Stack trace: 0 browser_tests 0x000000010cc0225b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 browser_tests 0x000000010cc01c29 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 browser_tests 0x000000010c9258a8 (anonymous namespace)::TextSuggestionsTouchBarControllerTest_MakeTouchBar_Test::RunTestOnMainThread() + 600 3 browser_tests 0x000000010f226e9b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 491 4 browser_tests 0x000000010ed1d4a7 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4375 5 browser_tests 0x000000010ed1c28e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 6 browser_tests 0x000000010d84ffe3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 7 browser_tests 0x000000010dc40297 content::StartupTaskRunner::RunAllTasksNow() + 39 8 browser_tests 0x000000010d84e788 content::BrowserMainLoop::CreateStartupTasks() + 712 9 browser_tests 0x000000010d852500 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 10 browser_tests 0x000000010d84c8c4 content::BrowserMain(content::MainFunctionParams const&) + 180 11 browser_tests 0x000000010eb51ad0 content::ContentMainRunnerImpl::Run(bool) + 592 12 browser_tests 0x0000000110bb1071 service_manager::Main(service_manager::MainParams const&) + 2849 13 browser_tests 0x000000010eb50da4 content::ContentMain(content::ContentMainParams const&) + 68 14 browser_tests 0x000000010f226ac9 content::BrowserTestBase::SetUp() + 2697 15 browser_tests 0x000000010eca277d InProcessBrowserTest::SetUp() + 621 16 browser_tests 0x000000010c92555e (anonymous namespace)::TextSuggestionsTouchBarControllerTest::SetUp() + 14
,
Aug 7
,
Aug 7
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9b352548bfed25b9888464e269b5d7c09b4672c commit e9b352548bfed25b9888464e269b5d7c09b4672c Author: Avi Drissman <avi@chromium.org> Date: Tue Aug 07 17:45:32 2018 Disabling one more failing test. BUG= 871740 TBR=tnijssen@google.com Change-Id: I6c19c03148cdd7f5499d2fba114690a4b258d8c8 Reviewed-on: https://chromium-review.googlesource.com/1165319 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581274} [modify] https://crrev.com/e9b352548bfed25b9888464e269b5d7c09b4672c/chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm
,
Aug 7
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2a9bf5a635a1ed7028fef962adc27793e04c20d commit a2a9bf5a635a1ed7028fef962adc27793e04c20d Author: Tessa Nijssen <tnijssen@google.com> Date: Wed Aug 08 15:31:37 2018 [Mac] Fix TextSuggestionsTouchBarController Browser Tests TextSuggestionsTouchBarController's browser tests were failing because WebContents::IsFocusedElementEditable() returned false even after a web page was loaded with an autofocused textfield. A WindowedNotificationObserver was added to observe a change in focus in a page. When the textfield is autofocused, this observer is notified. By waiting on this observer, the tests can guarantee that WebContents::IsFocusedElementEditable() is true and that the tests that rely on that condition will pass. Disabled tests were undisabled. Bug: 871740 Change-Id: I86ed07d8738fdc46f68e72b8c8ba8e9dc3f1d984 Reviewed-on: https://chromium-review.googlesource.com/1165782 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581569} [modify] https://crrev.com/a2a9bf5a635a1ed7028fef962adc27793e04c20d/chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm
,
Aug 8
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Aug 7