Omnibox keyboard shortcuts are broken |
|||||||
Issue descriptionArrow keys don't work in the omnibox. They should allow the user to iterate through suggestions and to exit the fake selection (pre-edit).
,
Aug 7
Will need a cherry-pick after verification. This is a trivial fix for a pretty serious usability regression for iPad users with keyboards
,
Aug 8
This has been labeled approved, but I think you meant request? Please fix. Also canary verification, please.
,
Aug 9
,
Aug 9
This bug requires manual review: Less than 22 days to go before AppStore submit on M69 Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 13
Canary verification before approval please.
,
Aug 16
Verified on 70.0.3524.0 canary and iPad Pro, arrow keys working correctly.
,
Aug 16
Approved
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51620763fc09eae86c803babedb289e04707b031 commit 51620763fc09eae86c803babedb289e04707b031 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Fri Aug 17 14:43:53 2018 Fix omnibox arrow key navigation. Fixes the navigation that was accidentally broken when implementing the paste&go menu item. Bug: 871723 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icff16acf5465afd95698e4203520ee05a6cee51a Reviewed-on: https://chromium-review.googlesource.com/1165146 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Elodie Banel <lod@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581242}(cherry picked from commit 3ebd35cf14f126216061ee03ef315951e2d453a6) Reviewed-on: https://chromium-review.googlesource.com/1179901 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#684} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/51620763fc09eae86c803babedb289e04707b031/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
,
Aug 22
Verified on iPad Pro 12'9 iOS 11.4.1 using keyboard hardware.Able to iterate through omnibox suggestions using the arrow keys
,
Aug 22
On 69.0.3497.53 Beta |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Aug 7