New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871723 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox keyboard shortcuts are broken

Project Member Reported by stkhapugin@chromium.org, Aug 7

Issue description

Arrow keys don't work in the omnibox. They should allow the user to iterate through suggestions and to exit the fake selection (pre-edit). 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ebd35cf14f126216061ee03ef315951e2d453a6

commit 3ebd35cf14f126216061ee03ef315951e2d453a6
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Tue Aug 07 16:12:22 2018

Fix omnibox arrow key navigation.

Fixes the navigation that was accidentally broken when implementing
the paste&go menu item.

Bug:  871723 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icff16acf5465afd95698e4203520ee05a6cee51a
Reviewed-on: https://chromium-review.googlesource.com/1165146
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581242}
[modify] https://crrev.com/3ebd35cf14f126216061ee03ef315951e2d453a6/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm

Labels: Merge-Approved-69
Status: Fixed (was: Started)
Will need a cherry-pick after verification. This is a trivial fix for a pretty serious usability regression for iPad users with keyboards
This has been labeled approved, but I think you meant request? Please fix.

Also canary verification, please.
Labels: -Merge-Approved-69 Merge-Request-69
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 9

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Less than 22 days to go before AppStore submit on M69
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Canary verification before approval please.
Verified on 70.0.3524.0 canary and iPad Pro, arrow keys working correctly.
Labels: -Hotlist-Merge-Review -Merge-Review-69 Merge-Approved-69
Approved
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51620763fc09eae86c803babedb289e04707b031

commit 51620763fc09eae86c803babedb289e04707b031
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Fri Aug 17 14:43:53 2018

Fix omnibox arrow key navigation.

Fixes the navigation that was accidentally broken when implementing
the paste&go menu item.

Bug:  871723 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icff16acf5465afd95698e4203520ee05a6cee51a
Reviewed-on: https://chromium-review.googlesource.com/1165146
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581242}(cherry picked from commit 3ebd35cf14f126216061ee03ef315951e2d453a6)
Reviewed-on: https://chromium-review.googlesource.com/1179901
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#684}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/51620763fc09eae86c803babedb289e04707b031/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm

Status: Verified (was: Fixed)
Verified on iPad Pro 12'9 iOS 11.4.1 using keyboard hardware.Able to iterate through omnibox suggestions using the arrow keys
On 69.0.3497.53 Beta

Sign in to add a comment