New issue
Advanced search Search tips

Issue 871720 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: SetIconAPITest.Overview



Sign in to add a comment

SetIconAPITest.Overview is Flaky

Project Member Reported by Findit, Aug 7

Issue description

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3

commit 1c472ffdfc0d6ba628f08e08c4558246f98c6bd3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Aug 07 11:26:06 2018

Revert "Fix flaky webrequest related network service tests in component builds"

This reverts commit 30d8a3b9d66558f01b026c11ffe7db2bbda6fc1e.

Reason for revert: Made SetIconAPITest.Overview test flaky (871720)

Original change's description:
> Fix flaky webrequest related network service tests in component builds
> 
> These tests needed some extra synchronization due to the changes made in
> http://crrev.com/c/1139048. These were flaking in component builds.
> 
> Bug:  871224 
> Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057
> Reviewed-on: https://chromium-review.googlesource.com/1163987
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580980}

TBR=jam@chromium.org,cduvall@chromium.org

Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  871224 ,  871720 
Reviewed-on: https://chromium-review.googlesource.com/1165122
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581195}
[modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative/declarative_apitest.cc
[modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
[modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc
[modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/background_xhr_browsertest.cc

Labels: -Sheriff-Chromium
Owner: cduvall@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444729a60f6700e82a9385392d584f1814cd9129

commit 444729a60f6700e82a9385392d584f1814cd9129
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Aug 08 23:09:54 2018

Reland "Fix flaky webrequest related network service tests in component builds"

This is a reland of 30d8a3b9d66558f01b026c11ffe7db2bbda6fc1e

This fixes an issue where FlushForTesting would timeout if the InterfacePtr
was destroyed in the middle of a flush. Also fixes a webview test that was
flaky on component builds.

Original change's description:
> Fix flaky webrequest related network service tests in component builds
>
> These tests needed some extra synchronization due to the changes made in
> http://crrev.com/c/1139048. These were flaking in component builds.
>
> Bug:  871224 
> Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057
> Reviewed-on: https://chromium-review.googlesource.com/1163987
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580980}

Bug:  871224 ,  871720 
Change-Id: Ib66c759ef422124f166583c57f89f0a56d92f841
Reviewed-on: https://chromium-review.googlesource.com/1165504
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581721}
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative/declarative_apitest.cc
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/background_xhr_browsertest.cc
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/extensions/test/data/web_view/apitest/main.js
[modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/mojo/public/cpp/bindings/lib/control_message_proxy.cc

Status: Fixed (was: Assigned)

Sign in to add a comment