Findit has detected flake occurrences for the test SetIconAPITest.Overview Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ud2luL1dpbjEwIFRlc3RzIHg2NC8yNjMwMS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1UyVjBTV052YmtGUVNWUmxjM1F1VDNabGNuWnBaWGM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SetIconAPITest.Overview&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ud2luL1dpbjEwIFRlc3RzIHg2NC8yNjMwMS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1UyVjBTV052YmtGUVNWUmxjM1F1VDNabGNuWnBaWGM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
Findit identified the culprit r580980 with confidence 70.0% in the config "chromium.win / Win10 Tests x64" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ud2luL1dpbjEwIFRlc3RzIHg2NC8yNjMwMS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1UyVjBTV052YmtGUVNWUmxjM1F1VDNabGNuWnBaWGM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SetIconAPITest.Overview&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ud2luL1dpbjEwIFRlc3RzIHg2NC8yNjMwMS9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBXaW5kb3dzLTEwLTE1MDYzL1UyVjBTV052YmtGUVNWUmxjM1F1VDNabGNuWnBaWGM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
https://chromium-review.googlesource.com/c/chromium/src/+/1165122
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3 commit 1c472ffdfc0d6ba628f08e08c4558246f98c6bd3 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Aug 07 11:26:06 2018 Revert "Fix flaky webrequest related network service tests in component builds" This reverts commit 30d8a3b9d66558f01b026c11ffe7db2bbda6fc1e. Reason for revert: Made SetIconAPITest.Overview test flaky (871720) Original change's description: > Fix flaky webrequest related network service tests in component builds > > These tests needed some extra synchronization due to the changes made in > http://crrev.com/c/1139048. These were flaking in component builds. > > Bug: 871224 > Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 > Reviewed-on: https://chromium-review.googlesource.com/1163987 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580980} TBR=jam@chromium.org,cduvall@chromium.org Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871224 , 871720 Reviewed-on: https://chromium-review.googlesource.com/1165122 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581195} [modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative/declarative_apitest.cc [modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc [modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc [modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/1c472ffdfc0d6ba628f08e08c4558246f98c6bd3/chrome/browser/extensions/background_xhr_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/444729a60f6700e82a9385392d584f1814cd9129 commit 444729a60f6700e82a9385392d584f1814cd9129 Author: Clark DuVall <cduvall@chromium.org> Date: Wed Aug 08 23:09:54 2018 Reland "Fix flaky webrequest related network service tests in component builds" This is a reland of 30d8a3b9d66558f01b026c11ffe7db2bbda6fc1e This fixes an issue where FlushForTesting would timeout if the InterfacePtr was destroyed in the middle of a flush. Also fixes a webview test that was flaky on component builds. Original change's description: > Fix flaky webrequest related network service tests in component builds > > These tests needed some extra synchronization due to the changes made in > http://crrev.com/c/1139048. These were flaking in component builds. > > Bug: 871224 > Change-Id: Ibe370f9b9c8ebb94ee1dd21ba204c06e91518057 > Reviewed-on: https://chromium-review.googlesource.com/1163987 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580980} Bug: 871224 , 871720 Change-Id: Ib66c759ef422124f166583c57f89f0a56d92f841 Reviewed-on: https://chromium-review.googlesource.com/1165504 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581721} [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative/declarative_apitest.cc [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/chrome/browser/extensions/background_xhr_browsertest.cc [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/extensions/test/data/web_view/apitest/main.js [modify] https://crrev.com/444729a60f6700e82a9385392d584f1814cd9129/mojo/public/cpp/bindings/lib/control_message_proxy.cc
Comment 1 by Findit
, Aug 7