Non-Regression: Actual: Unnecessary movement is seen with volume/brightness sliders when we minimize the Onscreen keyboard |
||
Issue descriptionChrome Version: 70.0.3511.0/10946.0.0 dev-channel Blaze,Candy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Enable Onscreen keyboard from ubertray >>pop it up (2)Press volume/brightness key >> close the Onscreen keyboard and observe volume/brightness sliders Actual: Unnecessary movement is seen with volume/brightness sliders when we minimize the Onscreen keyboard Expected: NO such unnecessary movements should be seen in volume/brightness sliders when we close the minimize the Onscreen keyboard This is a Non-Regression issue seen from M-69 Attached the screencast for reference..
,
Aug 8
Probably caused by https://chromium.googlesource.com/chromium/src/+/3e3220d49f21fc41dcc51e21c3680d7853fb3d38 The slider is anchored to the status area with a certain vertical offset value. When we open the accessibility VK, the shelf hides and the status area moves downwards. We then calculate the vertical offset value. When we hide the VK, the shelf shows and the status area moves upwards. Because the slide is anchored to the status area, it too moves up.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd1d1381bbdaa381eba7613abdb1ad0635f34d86 commit dd1d1381bbdaa381eba7613abdb1ad0635f34d86 Author: Darren Shen <shend@chromium.org> Date: Thu Aug 09 04:46:02 2018 [VK] Change tray bubbles to anchor on virtual keyboard if it's shown. In a previous patch [1], we changed the anchor insets for tray bubbles so that when the keyboard is shown, bubbles show above the keyboard. However, this causes a subtle bug with the accessibility virtual keyboard. When we open the accessibility VK, the status area / shelf moves downwards. We then show a bubble, which is positioned correctly relative to the VK due to [1]. However, when we hide the VK, the status area / shelf moves upwards. Because the bubble is anchored to the status area / shelf and still has the same insets, it will move up as well. To fix this, we change the bubble anchor bounds to return either the status area bounds or the virtual keyboard bounds depending on whether the keyboard is visible. [1] https://crrev.com/3e3220d49f21fc41dcc51e21c3680d7853fb3d38 Bug: 871718 Change-Id: I8f24e2ff26f8912f579c386755de8af512c6ed1d Reviewed-on: https://chromium-review.googlesource.com/1166766 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#581786} [modify] https://crrev.com/dd1d1381bbdaa381eba7613abdb1ad0635f34d86/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/dd1d1381bbdaa381eba7613abdb1ad0635f34d86/ash/system/tray/tray_background_view.cc [modify] https://crrev.com/dd1d1381bbdaa381eba7613abdb1ad0635f34d86/ash/system/tray/tray_container.cc [modify] https://crrev.com/dd1d1381bbdaa381eba7613abdb1ad0635f34d86/ash/system/tray/tray_container.h [modify] https://crrev.com/dd1d1381bbdaa381eba7613abdb1ad0635f34d86/ui/keyboard/keyboard_controller.cc
,
Aug 10
Should be fixed now. Please check again when the fix hits Canary/Dev. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by shend@chromium.org
, Aug 8Status: Assigned (was: Untriaged)