New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871703 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Aug 13
Cc:
yyushkina@chromium.org
kmilka@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 857256



Sign in to add a comment

[Missing Tests]: The directory that should default to shouldn’t be “This PC” or home directory but most recent

Project Member Reported by kkaluri@chromium.org, Aug 7 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/1f858421c7e65b53a64b9b0152e96535a6974873

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=867758


Thank you!

Comment 1 by sweilun@chromium.org, Aug 7

Cc: kmilka@chromium.org ramyan@chromium.org

Comment 2 by ramyan@chromium.org, Aug 7

Blocking: 857256
Cc: yyushkina@chromium.org
Adding  issue 857256  as a master bug for this, but I think it's ok to track this separately.

Comment 3 by twelling...@chromium.org, Aug 7

Labels: zine-triaged

Comment 4 by ramyan@chromium.org, Aug 10

Labels: -Pri-3 Pri-2
It'll be good to make a start on automated testing, so increasing the priority of this bug.

Comment 5 by sweilun@chromium.org, Aug 10

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ff86943b83c3239b574da4271a7312f0dbff9a5

commit 4ff86943b83c3239b574da4271a7312f0dbff9a5
Author: Weilun Shi <sweilun@chromium.org>
Date: Mon Aug 13 19:13:21 2018

[NTP] Automated test that FileSelected updates last selected directory

Writing a test for the new feature remembering the last selected
directory for user. This unit test is for CL:
1162712:[NTP] Upload file from the most recent directory

Bug:  871703 
Change-Id: I18769a34ae360ff9b51241178c0e9ffdfd6f8c29
Reviewed-on: https://chromium-review.googlesource.com/1171880
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582660}
[modify] https://crrev.com/4ff86943b83c3239b574da4271a7312f0dbff9a5/chrome/browser/ui/search/search_tab_helper.h
[modify] https://crrev.com/4ff86943b83c3239b574da4271a7312f0dbff9a5/chrome/browser/ui/search/search_tab_helper_unittest.cc

Comment 7 by sweilun@chromium.org, Aug 13

Status: Fixed (was: Started)
►

Sign in to add a comment