New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to remove thumbnails from NTP.

Reported by sanyam.g...@etouch.net, Aug 7

Issue description

Chrome Version: 70.0.3515.0 (Official Build)  Revision	0e3f811e74b63685424a1bc4ea46b4a85d8f3f2e-refs/branch-heads/3515@{#1} (32/64-bit)

OS: Windows(7,8,8.1,10), Linux(14.04) OS

Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Material Design Icons' under chrome://flags.

Steps to reproduce:
(1) Launch Chrome and navigate to NTP.
(2) Click on close(x) button of thumbnails and observe.

Actual Result  : Unable to remove thumbnails from NTP.
Expected Result: Thumbnails should be able to be removed from NTP.

This is a regression issue, broken in 'M-70' and will soon update the bisect info:
Good Build:70.0.3514.0(Revision: 580791)
Bad Build: 70.0.3515.0(Revision: 581084)
 
Actual_Result.mp4
699 KB View Download
Expected_Result.mp4
531 KB View Download
Cc: pnangunoori@chromium.org ramyan@chromium.org
Labels: hasbisect-per-revision OS-Mac
Owner: kristip...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 580948 (known good), but no later than 580949 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/631ac11aae294abc8b5a100a09e59af59aa6e229..c2111e0695751dcd6833f86930ea7905daef9494

Suspect: https://chromium.googlesource.com/chromium/src/+/c2111e0695751dcd6833f86930ea7905daef9494

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You..!!
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
As this is a recent regression adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Cc: yyushkina@chromium.org
Status: Started (was: Assigned)
Labels: zine-triaged
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd12c8a704dbbbf0451479246a904a013f34ffe7

commit cd12c8a704dbbbf0451479246a904a013f34ffe7
Author: kristipark <kristipark@chromium.org>
Date: Tue Aug 07 22:36:08 2018

[NTP] Fix delete tile and tile accessibility issues

Fixed tile deletion functionality. The id of the tile was not being
obtained correctly.

Also fixed various accessibility issues:
- Keyboard focus will start on the first input field of the edit
  dialog.
- The iframes now have titles instead of "frame 0".
- The "x" button on a tile will no longer remain visible after clicking
  and releasing with a mouse.
- The button labels for screen readers are now applied correctly.
- "Restore all" is now "Restore default shortcuts" in the shortcut
  removed notification.
- If custom links is enabled, pressing "backspace" or "delete" while
  the shortcut is focused will now delete the shortcut.

Also adjusted variable names to match their CSS name.

Bug:  871663 , 864357
Change-Id: I10135be42d9525931077daf0b7c859c60dd59e89
Reviewed-on: https://chromium-review.googlesource.com/1166028
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581374}
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/custom_links_edit.css
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/custom_links_edit.js
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/most_visited_single.css
[modify] https://crrev.com/cd12c8a704dbbbf0451479246a904a013f34ffe7/chrome/browser/resources/local_ntp/most_visited_single.js

Status: Fixed (was: Started)
Labels: TE-Verified-M70 TE-Verified-70.0.3516.0
Update:
Rechecked the above issue on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) machines using latest canary build #70.0.3516.0 and issue is fixed. Hence adding TE-Verified labels.

Please refer below attached screen-cast for reference.

Thank You.
Fixed_Result.mp4
561 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 8

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f929d60c62034874c772acd45f621993c9ee3e8

commit 4f929d60c62034874c772acd45f621993c9ee3e8
Author: kristipark <kristipark@chromium.org>
Date: Wed Aug 08 17:20:12 2018

[Merge M69] [NTP] Fix delete tile and tile accessibility issues

Fixed tile deletion functionality. The id of the tile was not being
obtained correctly.

Also fixed various accessibility issues:
- Keyboard focus will start on the first input field of the edit
  dialog.
- The iframes now have titles instead of "frame 0".
- The "x" button on a tile will no longer remain visible after clicking
  and releasing with a mouse.
- The button labels for screen readers are now applied correctly.
- "Restore all" is now "Restore default shortcuts" in the shortcut
  removed notification.
- If custom links is enabled, pressing "backspace" or "delete" while
  the shortcut is focused will now delete the shortcut.

Also adjusted variable names to match their CSS name.

Bug:  871663 , 864357
Change-Id: I10135be42d9525931077daf0b7c859c60dd59e89
Reviewed-on: https://chromium-review.googlesource.com/1166028
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581374}(cherry picked from commit cd12c8a704dbbbf0451479246a904a013f34ffe7)
Reviewed-on: https://chromium-review.googlesource.com/1167625
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#501}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/custom_links_edit.css
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/custom_links_edit.js
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/most_visited_single.css
[modify] https://crrev.com/4f929d60c62034874c772acd45f621993c9ee3e8/chrome/browser/resources/local_ntp/most_visited_single.js

Cc: gov...@chromium.org
Labels: Merge-Without-Approval
Status: Assigned (was: Fixed)
Revision 4f929d60c62034874c772acd45f621993c9ee3e8 was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! 

Please explain why this change was merged to the branch!
 
This was given merge approval in https://crbug/864357
Labels: -Merge-Without-Approval
Status: Fixed (was: Assigned)
Right! Sorry for the noise!
No problem, apologies for the confusion
Labels: TE-Verified-M69 TE-Verified-69.0.3497.32
Update:
Rechecked the above issue on Win(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) machines using latest canary build #69.0.3497.32 and issue is fixed. Hence adding TE-Verified labels.

Please refer below attached screen-cast for reference.

Thank You.
Fixed_Result.mp4
695 KB View Download
Labels: SupportedInRemoteNTP

Sign in to add a comment