dpapad@: here's another text box where spellchecking might be unwanted.

xiaochengh: dpapad is OOO. Can you take this since you landed several spellcheck related CLs?

This is pretty similar to  issue 867377 . The spellchecker behavior here is as expected, since the text box doesn't disable spellchecking on it.

The question is whether the text box needs spellchecking -- if not, spellcheck=false should be added to it.

thestig: I might not be the right person to decide print preview page behavior.

Could the printing owners decide whether spellchecking is wanted there, and either add spellcheck=false or close the issue? Thanks!

xiaochengh: Sure, we decided we'll keep the previous behavior without spellchecking. It does not make sense to perform spellchecking on printer names. 

It would have been nice if you told us about this ahead of time, instead of enabling spellchecking everywhere before we had a chance to evaluate whether it is the right thing for our WebUIs.

thestig: Sorry, didn't expect such side effects in WebUIs.

Anyway, there's a Blink runtime flag controlling the newly introduced spellchecker behaviors, which is enabled only in M69/70. If things don't go well before M69 reaches stable, we can simply disable it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff4e145a7dcb66639551c0d04021df93fd94f8b2

commit ff4e145a7dcb66639551c0d04021df93fd94f8b2
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Aug 15 04:05:32 2018

Print Preview: turn off spellcheck for search boxes and inputs

Bug:  871656 
Change-Id: I7b258a191788051187ea2066072d41997953e45b
Reviewed-on: https://chromium-review.googlesource.com/1174959
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583159}
[modify] https://crrev.com/ff4e145a7dcb66639551c0d04021df93fd94f8b2/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/ff4e145a7dcb66639551c0d04021df93fd94f8b2/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/ff4e145a7dcb66639551c0d04021df93fd94f8b2/chrome/browser/resources/print_preview/new/print_preview_search_box.html

Update:
Rechecked the above issue on Windows (7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS using latest canary build #70.0.3524.0 and issue is still reproducible. Red underline is still seen for entered text on print preview page.

please refer attached screencast for reference

Thank You...

Deleted: Canary_behaviour.mp4 340 KB

	Canary_behaviour.mp4 340 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f4df01be99759a79b0163ceeff4a411e4f6b4db

commit 0f4df01be99759a79b0163ceeff4a411e4f6b4db
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Aug 18 00:56:32 2018

Print Preview: remove spellcheck in old UI

Just in case we need to revert to the old UI in M70+, also fix the issue
in the old code.

Bug:  871656 
Change-Id: I2a5791888132bed32d057a5000118da11a47d1b4
Reviewed-on: https://chromium-review.googlesource.com/1177897
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584269}
[modify] https://crrev.com/0f4df01be99759a79b0163ceeff4a411e4f6b4db/chrome/browser/resources/print_preview/common/search_box.html
[modify] https://crrev.com/0f4df01be99759a79b0163ceeff4a411e4f6b4db/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.html
[modify] https://crrev.com/0f4df01be99759a79b0163ceeff4a411e4f6b4db/chrome/browser/resources/print_preview/settings/page_settings.html

Tested on the reported # 70.0.3514.0 and able to reproduce the issue. However, red underline is still not observed in latest Canary #70.0.3529.3.

rbpotter@ -- Could you please confirm what exactly is the fix as per the comment #8. So that we can verify accordingly.

Thanks!

The fix in comment 6 is for the new Print Preview UI (enable new print preview in chrome://flags), which we expect to be the default by the time M70 launches to Stable. The fix in comment 8 is for the old UI. So with the new print preview flag enabled, this should be fixed in 70.0.3524.0 and higher. With the flag disabled (so old UI), this should be fixed in 70.0.3526.0 and higher.

with respect to comment #10,
Rechecked the above issue with enabling new print UI flag and without enabling flag on Windows (7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.6,10.14) and Linux(14.04  LTS)OS using latest canary build #70.0.3530.0 and issue is fix.

Please refer below attached screencast for reference.

Thank You...

Deleted: Canary Behaviour_ With Print flag.mp4 475 KB

	Canary Behaviour_ With Print flag.mp4 475 KB View Download

Deleted: Canary Behaviour _Without New Print flag.mp4 395 KB

	Canary Behaviour _Without New Print flag.mp4 395 KB View Download