New issue
Advanced search Search tips

Issue 871651 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Crostini install dialog is shown for every launch of Terminal

Project Member Reported by nverne@chromium.org, Aug 7

Issue description

We do a MaybeUpgradeCrostini upgrade check from UserSessionManager. This is too early, and the result of the upgrade check is lost because the browser restarts.
 
Labels: -Pri-3 M-70 Pri-1
Owner: timloh@chromium.org
Because the result of the upgrade check is lost, CrostiniManager in the new browser session will behave as if the cros-termina component was never installed. 
(Depends on what flags you have enabled, e.g. force enable the Experimental Crostini flag to repro.)
Owner: nverne@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e27fc9fe693f740b018314e912dbdf53f2caa57

commit 8e27fc9fe693f740b018314e912dbdf53f2caa57
Author: Nicholas Verne <nverne@chromium.org>
Date: Thu Aug 09 07:16:42 2018

MaybeUpradeCrostini happens in the correct browser session

Previously, we would lose any CrostiniManager state set in UserSessionManager
because it quits and restarts the browser, killing the old CrostiniManager with
it.

Also fixed a bug where newly installing Termina didn't set the CrostiniManager
state variable correctly.

Bug:  871651 
Change-Id: I2cfa3288069fccd86280e4301cd4757eb656e02d
Reviewed-on: https://chromium-review.googlesource.com/1166271
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581815}
[modify] https://crrev.com/8e27fc9fe693f740b018314e912dbdf53f2caa57/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/8e27fc9fe693f740b018314e912dbdf53f2caa57/chrome/browser/chromeos/login/session/chrome_session_manager.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment