New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871645 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Port important network_ autotests to Tast

Project Member Reported by nya@chromium.org, Aug 7

Issue description

network_CheckCriticalProcesses was ported in  crbug.com/860371 .
Other network tests in bvt-cq are:

- network_DefaultProfileCreation
- network_DestinationVerification
- network_WiFiInvalidParameters
- network_WlanDriver

 
Cc: briannorris@chromium.org kirtika@chromium.org
Cc-ing Kirtika, as she emailed last year asking if she could help out with porting wifi tests (and I did a bad job replying since I was still figuring out some of the basics of how Tast should work -- sorry! :-/).

Here's some helpful info that she provided then:

---

Wifi priorities: 
(a) ability to run system utilities and parse their output easily (e.g. run 'iw wlan0 link' and grab the signal from the output for me).
(b) ability to read/write sysfs easily e.g. poke at counters exposed by firmware, increase/decrease logging. 
(c) ability to read/parse /var/log/* contents. 

A good 'rubber meets the road' test for a new framework - how short/simple is the equivalent of iw_runner.py in it? 
The current file is 950 lines of code, all to do ~25 functions, each of which would be a single bash line. :-/ (same for wifi_client.py and netperf_session.py). 

I assume other subsystems are similar (e.g. power/CPU relies a lot on parsing turbostat, just like we do on iw)

---
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/77b1a27ede193a90d48381a5e810d541f563b5df

commit 77b1a27ede193a90d48381a5e810d541f563b5df
Author: Shuhei Takahashi <nya@chromium.org>
Date: Wed Aug 08 11:29:20 2018

network: Port network_DefaultProfileCreation autotest.

BUG=chromium:871645
TEST=tast -verbose run DUT network.DefaultProfileCreation

Change-Id: Ice341b8e19a4f1b17d7610d61315d9e4bc4253a2
Reviewed-on: https://chromium-review.googlesource.com/1164727
Commit-Ready: Shuhei Takahashi <nya@chromium.org>
Tested-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/77b1a27ede193a90d48381a5e810d541f563b5df/src/chromiumos/tast/local/bundles/cros/main.go
[add] https://crrev.com/77b1a27ede193a90d48381a5e810d541f563b5df/src/chromiumos/tast/local/shill/shill.go
[add] https://crrev.com/77b1a27ede193a90d48381a5e810d541f563b5df/src/chromiumos/tast/local/bundles/cros/network/default_profile.go

Status: Available (was: Started)
After porting network_DefaultProfileCreation I don't have time to work on this, thus releasing for now.

Owner: ----
Cc: hidehiko@chromium.org
Components: OS>Systems>Network
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/36b55ed1852dddd5315a7d7d2efda4c90b04e46c

commit 36b55ed1852dddd5315a7d7d2efda4c90b04e46c
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Oct 25 03:07:19 2018

tast-tests: Port network_ShillStability

I shortened the timeout and interval, since a really-respawning shill
would actually happen more frequently than 10 seconds. And even with a
10-second respawn, 20 seconds should be enough to catch a restart or
two.

Some of getPID() was adapted from
src/chromiumos/tast/local/chrome/proc.go.

BUG=chromium:871645
TEST=`tast -verbose run $HOST network.ShillStability`, while:
 (a) running `restart shill` (FAIL);
 (b) starting up an extra shill process (FAIL); or
 (c) leaving things alone (PASS)

Change-Id: I0100eb3f542af1e235444e09857780851fddc778
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1296899
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[add] https://crrev.com/36b55ed1852dddd5315a7d7d2efda4c90b04e46c/src/chromiumos/tast/local/bundles/cros/network/shill_stability.go

Labels: Enterprise-Triaged

Sign in to add a comment