New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871639 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Cannot delete individuals cookies with long names from Settings.

Reported by rat...@gmail.com, Aug 7

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Steps to reproduce the problem:
1. Goto any site that uses very long cookie names.
2. Goto Settings and bring up the cookies for the site.
3. Observe that you do not have the option to delete cookies with very long names.

What is the expected behavior?
Should truncate the name in the list and show the expand and delete icons.

What went wrong?
The name takes up the whole table and you can no longer access the expand and delete icons. You can still expand and collapse by clicking on the name; however, you can delete.

Did this work before? N/A 

Chrome version: 68.0.3440.84  Channel: stable
OS Version: 10.0
Flash Version:
 
Chrome_Cannot_Delete_Cookie.png
21.3 KB View Download
Labels: Needs-Triage-M68
Components: UI>Settings
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
Thanks for filing the issue...

@Reporter : Tried with multiple sites but we are unable to find the very long cookie names, It would be really helpful if a sample URL is provided, so that we can investigate the issue further.

Thanks.!

Could I take this issue if there is no one working on this? :)

Comment 5 Deleted

I fixed this issue by following method. 

The CL is ready to review. (https://chromium-review.googlesource.com/c/chromium/src/+/1202362)


cookies_with_longnames.png
10.9 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad5078abe1c03f8a3593c54006be3a1c300d77d

commit dad5078abe1c03f8a3593c54006be3a1c300d77d
Author: Jdragon <jdragon.bae@gmail.com>
Date: Thu Sep 20 11:42:18 2018

Fix that cookies with long names can't be deleted

This change fix settings css to access expand and delete icons.
As a Result, cookies with long names can be deleted.

Bug:  871639 
Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42
Reviewed-on: https://chromium-review.googlesource.com/1202362
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592760}
[modify] https://crrev.com/dad5078abe1c03f8a3593c54006be3a1c300d77d/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/dad5078abe1c03f8a3593c54006be3a1c300d77d/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Cc: krajshree@chromium.org
jdragon.bae@ - Tried testing the issue by navigating to different sites but couldn't find any long cookie in chrome://settings.
Could you please provide sample url to verify the fix from our end.

Thanks...!! 
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51c7ec50350d18e5a26cb609d5b3b84ef155d9de

commit 51c7ec50350d18e5a26cb609d5b3b84ef155d9de
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Sep 21 17:01:17 2018

Revert "Fix that cookies with long names can't be deleted"

This reverts commit dad5078abe1c03f8a3593c54006be3a1c300d77d.

Reason for revert:  crbug.com/887868 

Original change's description:
> Fix that cookies with long names can't be deleted
> 
> This change fix settings css to access expand and delete icons.
> As a Result, cookies with long names can be deleted.
> 
> Bug:  871639 
> Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42
> Reviewed-on: https://chromium-review.googlesource.com/1202362
> Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592760}

TBR=stevenjb@chromium.org,jinho.bang@samsung.com,jdragon.bae@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  871639 
Change-Id: I3a2f8c3d75a91ddd54b406f2e4ca37e0f20db3cc
Reviewed-on: https://chromium-review.googlesource.com/1238813
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593232}
[modify] https://crrev.com/51c7ec50350d18e5a26cb609d5b3b84ef155d9de/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html
[modify] https://crrev.com/51c7ec50350d18e5a26cb609d5b3b84ef155d9de/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Comment 10 Deleted

 krajshree@ Here is sample url :)
http://ec2-52-7-215-33.compute-1.amazonaws.com/
I fixed this issue another way.
https://chromium-review.googlesource.com/c/chromium/src/+/1239953
longcookie_with_focus.png
13.5 KB View Download
I navigated to http://ec2-52-7-215-33.compute-1.amazonaws.com/ but I do not see a cookie with a long name to test. Can you provide a full repro (starting with clearing cookies)? Thanks!


I'm not sure what I'm expected to do with that git repro? I'm looking for a simple set of steps to reproduce this with.

Here is a much easier way to repro.

1) Go to www.google.com and open the dev tools.
2) Type the following in the console (this will create a cookie with a long name)

let value = '';
for(let i=0; i<1000; i++) value+='a';
document.cookie = `${value}=myCookie`

3) Go to chrome://settings/siteData. Look for www.google.com. Try to delete the cookie (delete button is not visible).


cookie_name.png
20.5 KB View Download
And a potential fix is to simply add "word-break: break-word" in CSS for cr-expand-button, see screenshot.
cookie_name_fixed.png
30.8 KB View Download
Labels: OS-Chrome OS-Linux OS-Mac
Owner: dpa...@chromium.org
Status: Started (was: Unconfirmed)
stevenjb@: Sorry, I was mistaken.

Steps to reproduce the problem:
1. Goto site (http://ec2-52-7-215-33.compute-1.amazonaws.com)
2. Goto Settings and bring up the cookies for the site.
3. Observe that you do not have the option to delete cookies with very long names.

Project Member

Comment 21 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/079433c8fd6ce5ba45eaa56c087bdc925b3c67c8

commit 079433c8fd6ce5ba45eaa56c087bdc925b3c67c8
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 11 02:54:15 2018

Settings WebUI: Fix case where a cookie with a long name can't be deleted.

The long name was not properly wrapped to multiple lines, causing the delete
button to not be visible.

Bug:  871639 
Change-Id: Ibd95caeb9345edb660f3a7032705c15d6d719325
Reviewed-on: https://chromium-review.googlesource.com/c/1274891
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598645}
[modify] https://crrev.com/079433c8fd6ce5ba45eaa56c087bdc925b3c67c8/chrome/browser/resources/settings/site_settings/site_data_details_subpage.html

Status: Fixed (was: Started)
Labels: TE-Verified-M71 TE-Verified-71.0.3578.0
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the reported version 68.0.3440.84 and the issue is fixed on the latest M-71 build 71.0.3578.0 as per comment #16.
Able to view the delete button for cookies with long names.

Attached is the screen cast for reference. 

Hence adding TE verified labels as the fix is working as intended.

Thanks..
871639-M71.mp4
1.5 MB View Download

Sign in to add a comment