New issue
Advanced search Search tips

Issue 871637 link

Starred by 4 users
Status: Duplicate
Merged: issue 874385
Owner: ----
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 874385



Sign in to add a comment

Use a reference for Event (Event&), instead of a pointer (Event*), where they never be nullptr

Project Member Reported by hayato@chromium.org, Aug 7 
In current renderer/{core, modules} codebase, there are a lot of functions which receive an Event object as a pointer, even though Event object is never nullptr there.

We should use a reference (Event&) as much as possible there.

At this point, it mostly just needs someone to do the legwork to get it done.

Comment 1 by hayato@chromium.org, Aug 7

Summary: Use a reference for Event (Event&), instead of a pointer (Event*), where they never be nullptr (was: Use a reference for Event (Event), instead of a pointer (Event*), where they never be nullptr)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c568461a49ea21a26597782deec31f3d8fa414a

commit 5c568461a49ea21a26597782deec31f3d8fa414a
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Aug 07 06:06:36 2018

Use a reference for an Event parameter where they never be nullptr

The most of changes are mechanical ones.

The interesting part is, for example, that the current EventDispatcher::dispatchEvent, takes a
pointer to Event (Event*), while it is doing DCHECK at the beginning, as follows:

> DCHECK(event_.Get());

Given that, we can use a reference there safely; the mechanical changes in this CL should be safe.

Since there are a lot of callers of event dispatcher (and other functions), I gave up doing every
necessary changes in one CL, so that the size of CL wouldn't become huge.

For this reason, I couldn't remove EventTarget::DispatchEvent(Event*), for example, yet in this CL,
which is now just calling a function which takes a reference, after doing DCHECK().

Once we can replace every usages of callers in follow-up CLs, a function which takes a pointer will
be removed. These efforts should be tracked in  bug 871637 .

BUG= 871637 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3f20e9a40dd3f950c87282101e968e893b1e8c2c
Reviewed-on: https://chromium-review.googlesource.com/1163591
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581145}
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/bindings/core/v8/rejected_promises.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/animation/animation.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/animation/animation.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/css/font_face_set.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/abort_signal.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/character_data.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/event_dispatcher.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/event_queue.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/scoped_event_queue.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/scoped_event_queue.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/events/window_event_context.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/dom/scripted_animation_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/commands/editing_commands_utilities.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/commands/replace_selection_command.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/commands/typing_command.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/editor.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/editor.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/ime/input_method_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/editing/selection_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/events/mouse_event.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/exported/shared_worker_repository_client_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/exported/web_form_control_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/fileapi/file_reader.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/frame/device_single_window_event_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/fullscreen/fullscreen.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/forms/html_form_control_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/forms/search_input_type.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_details_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_image_loader.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_source_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/html_style_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/track/text_track_cue.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/html/track/text_track_cue.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/event_handler.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/gesture_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/keyboard_event_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/mouse_event_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/mouse_wheel_event_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/pointer_event_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/scroll_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/input/touch_event_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/loader/appcache/application_cache_host.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/loader/image_loader.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/mojo/test/mojo_interface_interceptor.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/page/drag_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/page/focus_controller.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/animation/svg_smil_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/svg_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/svg_image_loader.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/svg_script_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/svg_style_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/svg/svg_use_element.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_progress_event_throttle.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/battery/battery_manager.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_event_dispatcher.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_event_dispatcher.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_request.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_request.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/installation/installation_service_impl.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element_test.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate_test.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/notifications/notification.h
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/speech/speech_recognition.cc
[modify] https://crrev.com/5c568461a49ea21a26597782deec31f3d8fa414a/third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a0529ac33f137fa3e850218415f5bda31dbaa88

commit 6a0529ac33f137fa3e850218415f5bda31dbaa88
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Aug 07 09:13:49 2018

Prefer EventTarget::DispatchEvent(Event&) to EventTarget::DispatchEvent(Event*)

This is a follow-up CL after http://crrev.com/581145.

Rewrite each caller of EventTarget::DispatchEvent(Event*) to use EventTarget::DispatchEvent(Event&).
Now we can remove EventTarget::DispatchEvent(Event*).

There are still a lot of other places where Event* should be replaced with Event&, which can be
addressed in another CL.

See also  http://crbug.com/871662 , where we might want to make various Event::Create(..) functions
return a reference, instead of a pointer.

BUG= 871637 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If2e04cbaeea4b540428937dea6a1f9eedf7821ba
Reviewed-on: https://chromium-review.googlesource.com/1164806
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581178}
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/editing/editing_utilities.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/html/track/html_track_element.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/core/xmlhttprequest/xml_http_request_upload.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/app_banner/app_banner_controller.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/cookie_store/cookie_store.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/eventsource/event_source.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/filesystem/file_writer.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate_test.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/mediarecorder/media_recorder.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/mediastream/media_devices.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/mediastream/media_stream.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/netinfo/network_information.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/notifications/notification.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/payments/payment_request.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/permissions/permission_status.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_window.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/presentation/presentation_availability.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/presentation/presentation_connection.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/presentation/presentation_connection_list.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/screen_orientation/screen_orientation_controller_impl.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/sensor/sensor.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/service_worker/service_worker.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/service_worker/service_worker_container.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/speech/speech_synthesis.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/vr/navigator_vr.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webaudio/base_audio_context.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webaudio/script_processor_node.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webgl/webgl2_compute_rendering_context.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webgl/webgl2_rendering_context.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webgl/webgl_rendering_context.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webmidi/midi_access.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webmidi/midi_input.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webmidi/midi_port.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/websockets/dom_websocket.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/webusb/usb.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/xr/xr.cc
[modify] https://crrev.com/6a0529ac33f137fa3e850218415f5bda31dbaa88/third_party/blink/renderer/modules/xr/xr_session.cc

Comment 4 by dtapu...@chromium.org, Aug 7 

This goes against the Google Style Guide where pointers are preferred and only const references should be used. Did we get acceptance on this?
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb

commit a617bafeffa615c5ed3456f3a0aeff99db8d0ddb
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Aug 08 06:38:50 2018

Use a reference for EventTarget::EnqueueEvent's event parameter

As part of  http://crbug.com/871637 .

This CL also touches LocalDOMWindow::{EnqueueWindowEvent, EnqueueDocumentEvent} as necessary.

Bug:  871637 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7c21419c27c4a59b2b4de541e5b2cb9a3001e98a
Reviewed-on: https://chromium-review.googlesource.com/1166616
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581487}
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/frame/csp/content_security_policy.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/core/page/pointer_lock_controller.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/modules/broadcastchannel/broadcast_channel.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/a617bafeffa615c5ed3456f3a0aeff99db8d0ddb/third_party/blink/renderer/modules/vr/navigator_vr.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77fe14d2e0398221d87a0d36319ea3720189655d

commit 77fe14d2e0398221d87a0d36319ea3720189655d
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Aug 08 08:36:57 2018

Use a const reference for EventTarget::KeepNodeInNode's event parameter

As part of  http://crbug.com/871637 .

This CL also makes EventTarget::KeepNodeInNode a const function.

Bug:  871637 
Change-Id: I490359954c6932239429bf78f7ad949496d73d70
Reviewed-on: https://chromium-review.googlesource.com/1166772
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581501}
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/core/dom/events/event_path.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_button_panel_element.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_elements_helper.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.h
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
[modify] https://crrev.com/77fe14d2e0398221d87a0d36319ea3720189655d/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.h

Comment 9 by hayato@chromium.org, Aug 9

Labels: Hotlist-GoodFirstBug
Status: Available (was: Assigned)
Let me make this available, and have Hotlist-GoodFirstBug label, so this legwork can be picked up by someone.

There are still a lot of places where Event* can be replaced with Event&.
Maybe DefaultEventHandler(Event*) would be a good starting point.

Comment 10 by hayato@chromium.org, Aug 15

Blocking: 874385

Comment 11 by hayato@chromium.org, Aug 15

Owner: ----
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9723d593646e6ca58d897f589c670e40b5d6e72

commit a9723d593646e6ca58d897f589c670e40b5d6e72
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Aug 17 05:07:58 2018

Use Event& instead of Event* as a parameter of DefaultEventHandler

When DefaultEventHandler is called, Event object was passed as a parameter.
and it is never nullptr. so it can be changed to reference instead of pointer.

Bug:  871637 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d3a838ab38393e786ae6cdd184baf4b94343613
Reviewed-on: https://chromium-review.googlesource.com/1175753
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583966}
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/events/ui_event.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/clear_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/clear_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/date_time_edit_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/date_time_edit_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/date_time_field_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/date_time_field_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_input_element_test.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_label_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_label_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_select_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_text_area_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/html_text_area_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/picker_indicator_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/picker_indicator_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/slider_thumb_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/slider_thumb_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/spin_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/spin_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/text_control_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/text_control_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/text_control_inner_elements.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/text_control_inner_elements.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/forms/text_field_input_type.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_dialog_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_dialog_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_frame_set_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_frame_set_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_plugin_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_summary_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/html_summary_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/media/media_document.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/html/media/media_document.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/svg/svg_a_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/core/svg/svg_a_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_mute_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_mute_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_enclosure_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_enclosure_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/elements/media_control_volume_slider_element.h
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/a9723d593646e6ca58d897f589c670e40b5d6e72/third_party/blink/renderer/modules/media_controls/media_controls_impl.h

Comment 13 by hayato@chromium.org, Aug 20

Blocking: -874385
Mergedinto: 874385
Status: Duplicate (was: Available)
Let's merge this into 874385, since people are using bug 874385.

Comment 14 by hayato@chromium.org, Aug 20

Blocking: 874385
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c7980acf6478020ebccf99619ca4756ac826dc

commit 49c7980acf6478020ebccf99619ca4756ac826dc
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Aug 20 04:32:52 2018

Use Event& instead of Event* as a parameter of PreDispatchEventHandler

When PreDispatchEventHandler is called, Event object was passed as a
parameter. and it is never nullptr.
so it can be changed to reference instead of pointer.

Bug:  871637 
Change-Id: Id8f1b05c51024e6418eaf2e7517f6dfb2ec70699
Reviewed-on: https://chromium-review.googlesource.com/1179520
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#584358}
[modify] https://crrev.com/49c7980acf6478020ebccf99619ca4756ac826dc/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/49c7980acf6478020ebccf99619ca4756ac826dc/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/49c7980acf6478020ebccf99619ca4756ac826dc/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/49c7980acf6478020ebccf99619ca4756ac826dc/third_party/blink/renderer/core/html/forms/html_input_element.h
[modify] https://crrev.com/49c7980acf6478020ebccf99619ca4756ac826dc/third_party/blink/renderer/core/html/forms/text_field_input_type.cc
►

Sign in to add a comment