New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871623 link

Starred by 2 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Aug 13
Cc:
klausw@chromium.org
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Missing gn dependency in //chrome/browser/android/vr

Project Member Reported by wychen@chromium.org, Aug 7 
1. Edit src/.gn, add or uncomment "//chrome/browser/android/*" in check_targets.
2. Run "gn check"

The error messages are:

ERROR at //chrome/browser/android/vr/controller_delegate_for_testing.cc:8:11: Include not allowed.
#include "chrome/browser/vr/test/constants.h"
          ^---------------------------------
It is not in any dependency of
  //chrome/browser/android/vr:vr_android
The include file is in the target(s):
  //chrome/browser/vr:vr_test_support
which should somehow be reachable.


Looks like we might want to add more gn targets to split out the files for testing.

Comment 1 by ddorwin@chromium.org, Aug 7

Cc: mthiesse@chromium.org
Labels: OS-Android
Owner: acondor@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c315ea03185e77804e9045d5826ff9e49354249

commit 3c315ea03185e77804e9045d5826ff9e49354249
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Mon Aug 13 20:45:09 2018

Fix gn dependencies for chrome/browser/android/vr

And enabling check for the whole chrome/browser/android directory.

Bug:  871623 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If89ad40bfe133451efc0fd27867e4f939404478a
Reviewed-on: https://chromium-review.googlesource.com/1165497
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582693}
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/.gn
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/arcore_device/arcore_gl.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/arcore_device/arcore_gl.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/gvr_controller_delegate.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/vr_shell_delegate.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/controller_delegate_for_testing.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/elements/content_element.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/elements/platform_ui_element.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/elements/platform_ui_element.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/elements/textured_element.cc
[add] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/gl_texture_location.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/keyboard_ui_interface.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/model/model.h
[add] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/render_info.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/render_loop.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/testapp/test_keyboard_renderer.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_interface.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_renderer.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_scene.h
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_scene_creator.cc
[delete] https://crrev.com/76a886bb7a95e6b9233b5e1249dc2b023a59a5aa/chrome/browser/vr/ui_test_input.cc
[modify] https://crrev.com/3c315ea03185e77804e9045d5826ff9e49354249/chrome/browser/vr/ui_test_input.h

Comment 3 by acondor@chromium.org, Aug 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment