Issue metadata
Sign in to add a comment
|
Support custom frame colors on Win 8 |
||||||||||||||||||||||
Issue descriptionIf ui::NativeTheme::GetInstanceForNativeUi()->UsesHighContrastColors() is true, we should ignore the DWM colors, and we should respect the system theme colors, which we hopefully get from GetSysColor, but if not, look in HKCU\Control Panel\Colors (under ActiveTitle and InactiveTitle). To add Win 8 support for the DWM colors, the active window titlebar color seems to be computed using the code we currently use to set dwm_accent_border_color_. The inactive window color seems to be 0xEBEBEB (hardcoded)?
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fc644dc54703533bbe72993ed825a589c185024 commit 6fc644dc54703533bbe72993ed825a589c185024 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Aug 08 13:10:34 2018 Support Win 8 custom frame colors better. Bug: 871619 Change-Id: I23704ee0321317cb8459c6ad6e80fc3d59a6c705 Reviewed-on: https://chromium-review.googlesource.com/1166035 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#581539} [modify] https://crrev.com/6fc644dc54703533bbe72993ed825a589c185024/chrome/browser/themes/theme_service_win.cc
,
Aug 8
,
Aug 8
Pls update bug with canary result tomorrow and pls justify the merge too. Thank you.
,
Aug 8
Will check on canary tomorrow. Merge justification is that this is a blocker for bug 862276 , which is aimed at M69. Marked that on here.
,
Aug 8
Thank you pkasting@. Also this feature is behind finch, correct?
,
Aug 8
This amounts to a bugfix of our current behavior (stop ignoring the window frame color on Win 8), so it's not controlled by Finch.
,
Aug 8
Ok, got it. Thank you.
,
Aug 9
The NextAction date has arrived: 2018-08-09
,
Aug 9
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9
,
Aug 9
@4: Verified that the change works correctly in Win 8 in Canary.
,
Aug 9
Thank you pkasting@. Approving merge to M69 branch 3497 based on comments #5 and #12.
,
Aug 9
,
Aug 9
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb91e273a5d93ad616227e08a83a8ee0415174d4 commit cb91e273a5d93ad616227e08a83a8ee0415174d4 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Aug 09 23:56:13 2018 Support Win 8 custom frame colors better. Bug: 871619 Change-Id: I23704ee0321317cb8459c6ad6e80fc3d59a6c705 Reviewed-on: https://chromium-review.googlesource.com/1166035 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581539}(cherry picked from commit 6fc644dc54703533bbe72993ed825a589c185024) Reviewed-on: https://chromium-review.googlesource.com/1169782 Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#527} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/cb91e273a5d93ad616227e08a83a8ee0415174d4/chrome/browser/themes/theme_service_win.cc
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Aug 8Summary: Support custom frame colors on Win 8 (was: Support custom frame colors on Win 8, high contrast)