No top drag indicator if drag a window from top in portrait screen orientation |
||
Issue descriptionWhat steps will reproduce the problem? (1) Rotate the screen in tablet mode to enter portrait screen orientation. (2) Drag an app window from top long enough to show the drag indicators. What is the expected result? No top drag indicator since window can not be snapped to top, only bottom drag indicator. What happens instead? Both top and bottom have drag indicators.
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/632ec8dbe970b1dd6ec37738e63a0c3df67e6185 commit 632ec8dbe970b1dd6ec37738e63a0c3df67e6185 Author: Min Chen <minch@google.com> Date: Wed Aug 15 21:32:08 2018 No top drag indicator if a window is dragged from top in portrait screen orientation. 1. Added IndicatorType kDragAreaLeft, kCannotSnapLeft to show only left/top drag indicator, kDragAreaRight, kCannotSnapRight to show only right/bottom drag indicator, only kDragAreRight and kCannotSnapRight are used in this change, but still added kDragAreLeft and kCannotSnapLeft to keep consistence. 2. Move the logic to update the opacity of highlight view and label view from SplitViewDragIndicators to SplitViewHighligtView and RotatedImageLabelView instead. see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiOGV3c0puTkJpTElBNUFSUlZpNEp6TElKUHJZ/view?usp=sharing Bug: 871607 Test: SplitViewTabDraggingTest.DragIndicatorsInPortraitOrientationTest Change-Id: I64f76766cd14dd2bca686be3f13d274993f24639 Reviewed-on: https://chromium-review.googlesource.com/1167998 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583405} [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_drag_indicators.cc [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_drag_indicators.h [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_highlight_view.cc [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_highlight_view.h [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_utils.cc [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/splitview/split_view_utils.h [modify] https://crrev.com/632ec8dbe970b1dd6ec37738e63a0c3df67e6185/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
,
Aug 15
|
||
►
Sign in to add a comment |
||
Comment 1 by minch@chromium.org
, Aug 8Labels: M-70
Status: Started (was: Assigned)
Summary: No top drag indicator if drag a window from top in portrait screen orientation (was: No top indicator if drag a window from top in portrait orientation)