Telemetry: testSmokeIsBrowserRunningReturnFalse failure on amd64-generic-telemetry |
||||||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938917111252909200 VMTest failure due to: 08/06 15:30:45.842 INFO |run_chromeos_tests:0052| [252/1160] telemetry.internal.backends.browser_backend_unittest.BrowserBackendIntegrationTest.testSmokeIsBrowserRunningReturnFalse failed unexpectedly 19.0348s: 08/06 15:30:45.844 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 08/06 15:30:45.845 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/testing/browser_test_case.py", line 89, in tearDownClass 08/06 15:30:45.846 INFO |run_chromeos_tests:0052| cls._browser.Close() 08/06 15:30:45.848 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 216, in Close 08/06 15:30:45.849 INFO |run_chromeos_tests:0052| self._browser_backend.Close() 08/06 15:30:45.850 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function 08/06 15:30:45.851 INFO |run_chromeos_tests:0052| return func(*args, **kwargs) 08/06 15:30:45.852 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 124, in Close 08/06 15:30:45.854 INFO |run_chromeos_tests:0052| py_utils.WaitFor(lambda: not self._IsCryptohomeMounted(), 180) 08/06 15:30:45.854 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/__init__.py", line 129, in WaitFor 08/06 15:30:45.855 INFO |run_chromeos_tests:0052| res = condition() 08/06 15:30:45.856 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 124, in <lambda> 08/06 15:30:45.856 INFO |run_chromeos_tests:0052| py_utils.WaitFor(lambda: not self._IsCryptohomeMounted(), 180) 08/06 15:30:45.857 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function 08/06 15:30:45.857 INFO |run_chromeos_tests:0052| return func(*args, **kwargs) 08/06 15:30:45.858 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 189, in _IsCryptohomeMounted 08/06 15:30:45.859 INFO |run_chromeos_tests:0052| return self._cri.IsCryptohomeMounted(username, self._is_guest) 08/06 15:30:45.859 INFO |run_chromeos_tests:0052| AttributeError: 'NoneType' object has no attribute 'IsCryptohomeMounted' perezju@ could you please triage?
,
Aug 8
I can take a look at this. Ahmed - could you please disable this test in the interim? Also please disable testVariationArgs as well: 08/08 12:17:31.693 INFO |run_chromeos_tests:0052| [218/264] core.perf_benchmark_unittest.PerfBenchmarkTest.testVariationArgs failed unexpectedly 0.0099s: 08/08 12:17:31.693 INFO |run_chromeos_tests:0052| Traceback (most recent call last): 08/08 12:17:31.694 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/perf_benchmark_unittest.py", line 72, in testVariationArgs 08/08 12:17:31.695 INFO |run_chromeos_tests:0052| benchmark.CustomizeBrowserOptions(options.browser_options) 08/08 12:17:31.695 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/perf_benchmark.py", line 94, in CustomizeBrowserOptions 08/08 12:17:31.696 INFO |run_chromeos_tests:0052| variations = self._GetVariationsBrowserArgs(options.finder_options) 08/08 12:17:31.696 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/perf_benchmark.py", line 130, in _GetVariationsBrowserArgs 08/08 12:17:31.697 INFO |run_chromeos_tests:0052| [self.FixupTargetOS(possible_browser.target_os)]) 08/08 12:17:31.697 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_util.py", line 61, in GenerateArgs 08/08 12:17:31.697 INFO |run_chromeos_tests:0052| platform_studies = fieldtrial_to_struct.ConfigToStudies(config, platforms) 08/08 12:17:31.698 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_to_struct.py", line 101, in ConfigToStudies 08/08 12:17:31.698 INFO |run_chromeos_tests:0052| return [study for study in _GenerateTrials(config, platforms)] 08/08 12:17:31.699 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_to_struct.py", line 92, in _GenerateTrials 08/08 12:17:31.699 INFO |run_chromeos_tests:0052| study = _CreateTrial(study_name, config[study_name], platforms) 08/08 12:17:31.700 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_to_struct.py", line 84, in _CreateTrial 08/08 12:17:31.700 INFO |run_chromeos_tests:0052| for e in config['experiments']] 08/08 12:17:31.701 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_to_struct.py", line 57, in _CreateExperiment 08/08 12:17:31.701 INFO |run_chromeos_tests:0052| 'platforms': [_PlatformEnumValue(p) for p in platforms], 08/08 12:17:31.702 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/tools/perf/core/../../variations/fieldtrial_to_struct.py", line 38, in _PlatformEnumValue 08/08 12:17:31.702 INFO |run_chromeos_tests:0052| assert platform in _platforms 08/08 12:17:31.703 INFO |run_chromeos_tests:0052| AssertionError
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/3c38d339a5218b50f3b0131d30169e7f5a7a8d88 commit 3c38d339a5218b50f3b0131d30169e7f5a7a8d88 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Wed Aug 08 23:58:55 2018 Disable testSmokeIsBrowserRunningReturnFalse on chromeos. Bug= chromium:871600 Test=bots TBR=nednguyen@google.com Change-Id: Ic93209f0b88453cfcb37c370077fe4e70a156592 Reviewed-on: https://chromium-review.googlesource.com/1168398 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/3c38d339a5218b50f3b0131d30169e7f5a7a8d88/telemetry/telemetry/internal/backends/browser_backend_unittest.py
,
Aug 9
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10eb4c48d01f635c940333fefcef7dd80f592a7e commit 10eb4c48d01f635c940333fefcef7dd80f592a7e Author: Achuith Bhandarkar <achuith@chromium.org> Date: Thu Aug 09 06:32:57 2018 Disable testVariationArgs on chromeos. BUG= chromium:871600 TEST=bots TBR=nednguyen@google.com Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I5746a02cea032ce44f77dae6b47958f31d8c16f0 Reviewed-on: https://chromium-review.googlesource.com/1168477 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#581810} [modify] https://crrev.com/10eb4c48d01f635c940333fefcef7dd80f592a7e/tools/perf/core/perf_benchmark_unittest.py
,
Aug 10
I supposed catapult didn't uprev yet since the test failure is still seen?
,
Aug 10
The catapult roller rolls the telemetry change into chrome (which I think happened), and the perf change is already in chrome. Chrome also needs to uprev, but the PFQ is red as you know.
,
Aug 10
I thought amd64-generic-telemetry is using ToT chrome since it's one of the informational builders.
,
Aug 10
You're right - I remember it being that way once upon a time, but I think the last couple of failures only went away after a green PFQ run. I wonder what changed?
,
Aug 14
https://chromium-review.googlesource.com/c/chromium/src/+/1173138 https://chromium-review.googlesource.com/c/catapult/+/1173534 Filed http://crbug.com/873804 for amd64-generic-telemetry
,
Aug 14
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/fe19ddfb2910e17c425b8387681156bf15fc1a0b commit fe19ddfb2910e17c425b8387681156bf15fc1a0b Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Aug 14 08:22:48 2018 _IsCryptohomeMounted requires CrOSInterface. Bug= chromium:871600 Change-Id: Idb21d2ef5c9018a9a929f3300d7eb2c814f3d856 Reviewed-on: https://chromium-review.googlesource.com/1173534 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> [modify] https://crrev.com/fe19ddfb2910e17c425b8387681156bf15fc1a0b/telemetry/telemetry/internal/backends/browser_backend_unittest.py [modify] https://crrev.com/fe19ddfb2910e17c425b8387681156bf15fc1a0b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d73d51c296c11a1f7367daad7e2c01d2a398ab commit 91d73d51c296c11a1f7367daad7e2c01d2a398ab Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Aug 14 08:24:41 2018 variations uses osname chromeos, not cros. Bug= chromium:871600 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I09f909050620f8d2e2e9a1fdedbe2c7091732128 Reviewed-on: https://chromium-review.googlesource.com/1173138 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582865} [modify] https://crrev.com/91d73d51c296c11a1f7367daad7e2c01d2a398ab/tools/perf/core/perf_benchmark.py [modify] https://crrev.com/91d73d51c296c11a1f7367daad7e2c01d2a398ab/tools/perf/core/perf_benchmark_unittest.py
,
Aug 14
Re-enabled both tests and bot is green. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nednguyen@chromium.org
, Aug 7Owner: achuith@chromium.org