Tracking bug for adding browser tests to Fuchsia.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a60f01228557982e6508c5919cc21fcfddf110b commit 6a60f01228557982e6508c5919cc21fcfddf110b Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Aug 17 19:47:41 2018 [fuchsia] Implement browser tests for WebRunner Context service. Tests may interact with the WebRunner FIDL services and the underlying browser objects for end to end testing of service and browser functionality. * Add a browser test launcher main() for WebRunner. * Add some simple navigation tests. * Wire up GoBack()/GoForward() FIDL calls. * Add embedded test server resources and initialization logic. * Add missing deletion & notification calls to BrowserContext dtor. * Use FIDL events for navigation state changes. * Bug fixes: ** Move BrowserContext and Screen deletion to PostMainMessageLoopRun(), so that they may use the MessageLoop during teardown. ** Fix Frame dtor to allow for null WindowTreeHosts (headless case) ** Fix std::move logic in Frame ctor which lead to no WebContents observer being registered. Bug: 871594 Change-Id: I36bcbd2436d534d366c6be4eeb54b9f9feadd1ac Reviewed-on: https://chromium-review.googlesource.com/1164539 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584155} [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/content/common/sandbox_policy_fuchsia.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/BUILD.gn [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/app/component_controller_impl.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/app/component_controller_impl.h [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/DEPS [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/context_impl.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/context_impl.h [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/context_impl_browsertest.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/frame_impl.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/frame_impl.h [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/test/data/title1.html [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/test/data/title2.html [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_browser_context.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_browser_main_parts.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_browser_main_parts.h [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_browser_test.cc [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_browser_test.h [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_content_browser_client.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_content_browser_client.h [add] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/browser/webrunner_test_launcher.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/fidl/context.fidl [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/fidl/frame.fidl [delete] https://crrev.com/343657ff0a9bbe36f41d9f76437b27a2f0b459cd/webrunner/fidl/frame_observer.fidl [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/service/common.h [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/service/webrunner_main_delegate.cc [modify] https://crrev.com/6a60f01228557982e6508c5919cc21fcfddf110b/webrunner/service/webrunner_main_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68b558bd211a716c673f5c045b889c073fdd710 commit b68b558bd211a716c673f5c045b889c073fdd710 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Aug 21 06:26:34 2018 [fuchsia] Add webrunner unit tests, browsertests to Fuchsia bots. * Fixed webrunner_unittests (tests were not being exercised, so the test code drifted from the impl) * Added webrunner_unittests, webrunner_browsertests to Fuchsia test bot list. Bug: 871594 Change-Id: I3f86f2f1d76534c51236a3dea43dc898d996b121 Reviewed-on: https://chromium-review.googlesource.com/1174868 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584669} [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/testing/buildbot/chromium.linux.json [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/testing/buildbot/test_suites.pyl [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/webrunner/BUILD.gn [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/webrunner/service/context_provider_impl.cc [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/webrunner/service/context_provider_impl.h [modify] https://crrev.com/b68b558bd211a716c673f5c045b889c073fdd710/webrunner/service/context_provider_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc8f939820dc535c580ce3f94c62d4fc99c8651 commit 7fc8f939820dc535c580ce3f94c62d4fc99c8651 Author: Kevin Marshall <kmarshall@chromium.org> Date: Mon Oct 08 18:35:08 2018 [fuchsia] Refactor browsertests into Context and Frame specific suites. context_impl_browsertest.cc was running the risk of becoming a large catch-all for all browsertests. This CL breaks the existing tests into Context- and Frame-specific suites, which should be a more manageable structure going forward. Bug: 871594 Change-Id: Ic26bb0a070088d48b51f7f47d6737ebb311a6efe Reviewed-on: https://chromium-review.googlesource.com/c/1255897 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597621} [modify] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/BUILD.gn [modify] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/context_impl_browsertest.cc [modify] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/frame_impl.h [add] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/frame_impl_browsertest.cc [add] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/test_common.cc [add] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/test_common.h [modify] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/webrunner_browser_test.cc [modify] https://crrev.com/7fc8f939820dc535c580ce3f94c62d4fc99c8651/webrunner/browser/webrunner_browser_test.h
Comment 1 by bugdroid1@chromium.org
, Aug 17