New issue
Advanced search Search tips

Issue 871549 link

Starred by 3 users
Status: Fixed
Owner:
jam@chromium.org
Closed: Aug 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 844928


Sign in to add a comment

Fix PolicyTest.Extension* tests when network service is enabled

Project Member Reported by mmenke@chromium.org, Aug 6 
These tests uses net::URLRequestFilter (through TestRequestInterceptor) to mock out network responses, and use ExtensionDownloader to issue requests, which has yet to be switched to URLFetcher.

See mojo.fyi/network_browser_tests.filter to see the list of disabled tests.

Comment 1 by jam@chromium.org, Aug 7

Owner: jam@chromium.org
Status: Started (was: Untriaged)
Thanks for filing, I was just looking at these tests so I'll take this on.

Comment 2 by jam@chromium.org, Aug 7

Labels: -Proj-Servicification-Canary Proj-Servicification Hotlist-KnownIssue

Comment 3 by jam@chromium.org, Aug 7 

re extensiondownloader, i've pinged folks and https://chromium-review.googlesource.com/c/chromium/src/+/1066370 should be ready to land to unblock the tests.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580bc96a5dcb4b1c307304e2bbd32ffa9a777d49

commit 580bc96a5dcb4b1c307304e2bbd32ffa9a777d49
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Aug 10 02:24:47 2018

Fix extensions policy browser tests with network service.

Bug:  871549 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I53fe4c0163964961e1a44fa9f81b95e63c395433
Reviewed-on: https://chromium-review.googlesource.com/1167989
Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582024}
[modify] https://crrev.com/580bc96a5dcb4b1c307304e2bbd32ffa9a777d49/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/580bc96a5dcb4b1c307304e2bbd32ffa9a777d49/chrome/test/data/extensions/good2_update_manifest.xml
[modify] https://crrev.com/580bc96a5dcb4b1c307304e2bbd32ffa9a777d49/chrome/test/data/extensions/good_v1_update_manifest.xml
[modify] https://crrev.com/580bc96a5dcb4b1c307304e2bbd32ffa9a777d49/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 5 by jam@chromium.org, Aug 13

Status: Fixed (was: Started)
►

Sign in to add a comment