Issue 871454 link

Starred by 2 users

Issue metadata

Status:	Started
Owner:	█ robert...@chromium.org Last visit > 30 days ago
Cc:	█ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt>Flakiness
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	----

Isolated target index is not populating gitiles fields when ingesting build information

Project Member Reported by st...@chromium.org, Aug 6

Issue description

Page URL: https://16905-5ed46a8-dot-frontend-dot-findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84MjM0Ny9zeW5jX2ludGVncmF0aW9uX3Rlc3RzL1ZWTlRMMVIzYjBOc2FXVnVkRUp2YjJ0dFlYSnJjMU41Ym1OVVpYTjBTVzVqYkhWa2FXNW5WWE56VkdWemRITXVUVU5mVUdGeVpXNTBSR1ZzWlhSbFEyaHBiR1JTWlc1aGJXVkRiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA

 Description:

For r580433, the flake analysis pipeline still ran compile job to build the test binary https://screenshot.googleplex.com/wR4i7f1Licy.png
However, Findit already has the binary in our datastore https://screenshot.googleplex.com/U1q0acmuUjy.png or https://pantheon.corp.google.com/datastore/entities/query?project=findit-for-me&ns=&kind=IsolatedTarget&filter=11%2Ftarget_name%7CSTR%7CEQ%7C22%2Fsync_integration_tests&filter=15%2Fcommit_position%7CINT%7CEQ%7C6%2F580433&filter=12%2Fbuilder_name%7CSTR%7CEQ%7C11%2FWin%20Builder

The binary was built in the original analysis at least https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLndpbi9XaW43IFRlc3RzICgxKS84MjM0Ny9zeW5jX2ludGVncmF0aW9uX3Rlc3RzL1ZWTlRMMVIzYjBOc2FXVnVkRUp2YjJ0dFlYSnJjMU41Ym1OVVpYTjBTVzVqYkhWa2FXNW5WWE56VkdWemRITXVUVU5mVUdGeVpXNTBSR1ZzWlhSbFEyaHBiR1JTWlc1aGJXVkRiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Comment 1 by lijeffrey@chromium.org, Aug 28

Owner: robert...@chromium.org

The root cause is "gitiles_host" and "gitiles_project", aren't set, however the query for IsolatedTarget.FindIsolateAtOrAftercommitPositionByMaster checks for gitiles_host and gitiles_project.

@robertocn, can you ptal?

Comment 2 by robert...@chromium.org, Aug 28

On it.

Comment 3 by robert...@chromium.org, Aug 28

Status: Started (was: Assigned)

Comment 4 by robert...@chromium.org, Aug 28

Summary: Isolated target index is not populating gitiles fields when ingesting build information (was: Archived isolated binary was not properly used in flake analysis)

Comment 5 by robert...@chromium.org, Aug 28

This seems limited to builds produced by findit's own tryjobs.

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5c4fd8468029ef42a2edaafe240de7745bb274ed

commit 5c4fd8468029ef42a2edaafe240de7745bb274ed
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Aug 28 20:12:39 2018

[Findit] Set repository property for flake tryjobs.

This property is needed for the isolated target ingestor to derive the
gitiles_host and gitiles_project column values.

R=lijeffrey,stgao,chanli,liaoyuke

Bug: 871454
Change-Id: I63f70204078e47caf40e25259dd58539206ca220
Reviewed-on: https://chromium-review.googlesource.com/1194298
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/5c4fd8468029ef42a2edaafe240de7745bb274ed/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/5c4fd8468029ef42a2edaafe240de7745bb274ed/appengine/findit/services/flake_failure/test/flake_try_job_test.py

►

Issue 871454 link

Issue metadata

Isolated target index is not populating gitiles fields when ingesting build information

Issue description

Comment 1 by lijeffrey@chromium.org, Aug 28

Comment 1 Deleted

Comment 2 by robert...@chromium.org, Aug 28

Comment 2 Deleted

Comment 3 by robert...@chromium.org, Aug 28

Comment 3 Deleted

Comment 4 by robert...@chromium.org, Aug 28

Comment 4 Deleted

Comment 5 by robert...@chromium.org, Aug 28

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Aug 28

Comment 6 Deleted

Sign in to add a comment