New issue
Advanced search Search tips

Issue 871445 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

"http/tests/media/video-load-metadata-decode-error.html" fails on Mac bots without GPUs

Project Member Reported by bpastene@chromium.org, Aug 6

Issue description

See https://chromium-review.googlesource.com/c/chromium/src/+/1162963/2 where I tried to stop running webkit_layout_tests on macs w/ GPUs. The three mac_chromium_rel_ng runs failed http/tests/media/video-load-metadata-decode-error.html consistently, presumably due to no available GPU:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/110733
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/111383
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/111452

I'll disable it for now so we can break the dependency on GPUs.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e64c72b93c42763e3adc6ff37568737400bb33f2

commit e64c72b93c42763e3adc6ff37568737400bb33f2
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Aug 07 00:49:00 2018

Stop running webkit_layout_tests on mac 10.12 and 10.13 w/ GPUs.

And disable http/tests/media/video-load-metadata-decode-error.html,
which appears to have a dependency on GPUs.

Bug: 854874, 871445
Change-Id: I254ce21953ac428351203d6479e1936347ce5b4c
Reviewed-on: https://chromium-review.googlesource.com/1162963
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581074}
[modify] https://crrev.com/e64c72b93c42763e3adc6ff37568737400bb33f2/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/e64c72b93c42763e3adc6ff37568737400bb33f2/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/e64c72b93c42763e3adc6ff37568737400bb33f2/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9dbd6694b895b29eddc6db9805dc9348c0c516a

commit b9dbd6694b895b29eddc6db9805dc9348c0c516a
Author: Ben Pastene <bpastene@chromium.org>
Date: Tue Aug 07 18:54:13 2018

Revert "Stop running webkit_layout_tests on mac 10.12 and 10.13 w/ GPUs."

This reverts commit e64c72b93c42763e3adc6ff37568737400bb33f2.

Reason for revert: This causes the https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests bot to turn red with webkit_layout_tests failures that are empty.

Original change's description:
> Stop running webkit_layout_tests on mac 10.12 and 10.13 w/ GPUs.
>
> And disable http/tests/media/video-load-metadata-decode-error.html,
> which appears to have a dependency on GPUs.
>
> Bug: 854874, 871445
> Change-Id: I254ce21953ac428351203d6479e1936347ce5b4c
> Reviewed-on: https://chromium-review.googlesource.com/1162963
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581074}

TBR=dpranke@chromium.org,kbr@chromium.org,bpastene@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854874, 871445, 871830
Change-Id: Ia9963a9f3cb6dbaad0f7a8b78723bf0dc034d052
Reviewed-on: https://chromium-review.googlesource.com/1165846
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581297}
[modify] https://crrev.com/b9dbd6694b895b29eddc6db9805dc9348c0c516a/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/b9dbd6694b895b29eddc6db9805dc9348c0c516a/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/b9dbd6694b895b29eddc6db9805dc9348c0c516a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/080298e7c33a24f90c1b125aec0fae0d86e1c52c

commit 080298e7c33a24f90c1b125aec0fae0d86e1c52c
Author: Ben Pastene <bpastene@chromium.org>
Date: Wed Aug 08 23:55:49 2018

Reland: Stop only running webkit_layout_tests on mac 10.13 w/ GPUs.

And disable http/tests/media/video-load-metadata-decode-error.html,
which appears to have a dependency on GPUs.

Fixes to original change:
- Instead of targeting bots w/o GPUs, this instead targets any 10.12 bot (GPUs or not).
- Doesn't change the suite on the Mac10.12 builder since all 10.12 bots have GPUs:
https://chromium.googlesource.com/chromium/src/+/2021963d6d4b6204fb4c935f487631e577ffc6ae/testing/buildbot/waterfalls.pyl#2892

Bug: 854874, 871445
Change-Id: Idf3603785500fe3aeee3f978e4e4f7ec18c76ba4
Reviewed-on: https://chromium-review.googlesource.com/1166338
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581724}
[modify] https://crrev.com/080298e7c33a24f90c1b125aec0fae0d86e1c52c/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/080298e7c33a24f90c1b125aec0fae0d86e1c52c/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/080298e7c33a24f90c1b125aec0fae0d86e1c52c/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment