New issue
Advanced search Search tips

Issue 871443 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Aug 7
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] HostListService state_ not initialized

Project Member Reported by yuweih@chromium.org, Aug 6 
state_ is not initialized when the HostListService is created. Currently for some reason we don't see any flakiness from the test, but I can see it failing when I try to add new tests.

It should be initialized to State::NOT_FETCHED
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45521c75f25b91ef644a78363339061a8aae1b9e

commit 45521c75f25b91ef644a78363339061a8aae1b9e
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Aug 06 21:30:57 2018

[CRD iOS] Initialize HostListService::state_

HostListService::state_ is uninitialized when the instance is created.
For some reason it hasn't caused any flakiness in the current unit test
set, but I can see it start failing when I try to add new tests.

This CL initializes state_ to State::NOT_FETCHED.

Bug:  871443 
Change-Id: I7eb3d69483baeb8ae0918122b5ba61300705be87
Reviewed-on: https://chromium-review.googlesource.com/1164181
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580992}
[modify] https://crrev.com/45521c75f25b91ef644a78363339061a8aae1b9e/remoting/ios/facade/host_list_service.h

Comment 2 by yuweih@chromium.org, Aug 7

Status: Fixed (was: Assigned)
►

Sign in to add a comment