New issue
Advanced search Search tips

Issue 871440 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 869940



Sign in to add a comment

Make run_suite_skylab use fallback to trigger normal suite.

Project Member Reported by xixuan@chromium.org, Aug 6

Issue description

It will be used in release builder and suite-scheduler.
 
Blocking: 869940
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c79b1b70f42e63c0693507177b1d9f67ac2829ca

commit c79b1b70f42e63c0693507177b1d9f67ac2829ca
Author: Xixuan Wu <xixuan@chromium.org>
Date: Thu Aug 09 21:25:32 2018

autotest: Add 'use-fallback' to run_suite_skylab

For release builder or suite-scheduler, normal suites will be scheduled
on DUTs, but there's no provision stage executed on them before.
So we want to first schedule on DUTs with the given build. If there's no
such DUTs, fallback to schedule it on other DUTs.

BUG= chromium:871440 
TEST=Run it on cros-skylab-suite-server1.hot.

Change-Id: I029392cf9cb3ff69fd0bb71302ad522f3f859972
Reviewed-on: https://chromium-review.googlesource.com/1164541
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/c79b1b70f42e63c0693507177b1d9f67ac2829ca/venv/skylab_suite/suite_runner.py
[modify] https://crrev.com/c79b1b70f42e63c0693507177b1d9f67ac2829ca/venv/skylab_suite/suite_parser.py
[modify] https://crrev.com/c79b1b70f42e63c0693507177b1d9f67ac2829ca/venv/skylab_suite/cros_suite.py
[modify] https://crrev.com/c79b1b70f42e63c0693507177b1d9f67ac2829ca/venv/skylab_suite/cmd/run_suite_skylab.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6aa6b3360e405779896219465cf306a5772a3b39

commit 6aa6b3360e405779896219465cf306a5772a3b39
Author: Xixuan Wu <xixuan@chromium.org>
Date: Thu Aug 09 21:27:17 2018

autotest: Pass build to fallback cmd.

This CL is to make sure if the DUT is not provisioned before, build is
passed to swarming-worker as provision-label to make this DUT be
provisioned first.

BUG= chromium:871440 
TEST=Run it on cros-skylab-suite-server1.hot

Change-Id: I7e1fb00c4ffc8d59c8dd6769f28a99ed7a42054c
Reviewed-on: https://chromium-review.googlesource.com/1165684
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/6aa6b3360e405779896219465cf306a5772a3b39/venv/skylab_suite/suite_runner.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/364a4495b53b3ba034cb3375f71a24df6216a298

commit 364a4495b53b3ba034cb3375f71a24df6216a298
Author: Xixuan Wu <xixuan@chromium.org>
Date: Thu Aug 09 21:29:14 2018

autotest: Remove 'is_provision' for refactoring

BUG= chromium:871440 
TEST=Run it on cros-skylab-suite-server1.hot

Change-Id: If2cebfede1614795f137946365f9a77a859036fa
Reviewed-on: https://chromium-review.googlesource.com/1165690
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/364a4495b53b3ba034cb3375f71a24df6216a298/venv/skylab_suite/suite_runner.py
[modify] https://crrev.com/364a4495b53b3ba034cb3375f71a24df6216a298/venv/skylab_suite/cros_suite.py

Status: Verified (was: Assigned)

Sign in to add a comment