New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871434 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Compat



Sign in to add a comment

GLSL bug: const struct requires use as const parameter

Reported by fabrice....@gmail.com, Aug 6

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36

Example URL:
https://www.shadertoy.com/view/Xl3cRs

Steps to reproduce the problem:
see URL:
1. struct S { ...
2. const S s ...
3. bool Intersect( S s) { ...

What is the expected behavior?
compiles

What went wrong?
does not compile on mu nvidia/linux 
if not bool Intersect( const S s) { 
( or S made not const )

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? No
 firefox

Chrome version: 68.0.3440.84  Channel: stable
OS Version: 14.04
Flash Version: Shockwave Flash 30.0 r0

driver NVIDIA 396.45 / ubuntu 14.04 & 16?04

May somebody please set the flags
Blink>WebGL
Internals>GPU>ANGLE 
?
thanks !
 
Labels: Needs-Triage-M68
Components: Blink>WebGL
Cc: oetu...@nvidia.com
Olli's been looking at many issues with structs in GLSL. Olli, could you please help triage this?

Labels: Triaged-ET TE-NeedsTriageHelp
fabrice.neyret@ Thanks for the issue.

This issue seems to be out of scope of triaging at TE end. As per comment #3, adding TE-NeedsTriageHelp label and requesting oetuaho@ to look into the issue and help in further triaging.

Thanks..
Cc: -oetu...@nvidia.com
Labels: OS-Windows
Owner: oetu...@nvidia.com
Status: Assigned (was: Unconfirmed)
I submitted a minimal test for the WebGL conformance tests:

https://github.com/KhronosGroup/WebGL/pull/2693

It passes on DX but fails on NVIDIA's GL driver also on Windows. Root cause seems to be in the GL driver, I filed a bug against the driver team. It may be possible to work around this in ANGLE, I'll also look into that.
great ! 
thanks.
Owner: ----
Status: Available (was: Assigned)
I'm not going to be working on a workaround, so marking this as available. Root bug is still waiting to be fixed in the NVIDIA driver.
Cc: kkinnu...@nvidia.com
Labels: GPU-NVidia
This is nvidia bug number 2321899.
If I undersatnd correctly, we have fixed this but I'm not certain if the driver is out. I'll check.
Bug is fixed in all drivers built in the last two months, so I think it is safe to close this.
Cc: jdarpinian@chromium.org
Maybe we should use this issue to track enabling the test Olli added in #c5 on our bots?
Blockedon: 887241
Is the fix in the driver on the latest public Shield TV update? If not, do you have an estimate for when the updated driver will make it to a public Shield TV update?
Blockedon: -887241
Sorry, false alarm. This has not been fixed in any public driver.

Removing bug 887241 as that deals specifically about 24.21.14.1195. This bug is not fixed in that.

This is scheduled to be released along with a new branch some time in the spring time-frame. Feedback for prioritization is accepted.

I'll update more once the upcoming version number is available.

Comment 14 by kkinnu...@nvidia.com, Jan 17 (5 days ago)

Cc: kbr@chromium.org jhelfe...@nvidia.com fs...@chromium.org
 Issue 874620  has been merged into this issue.

Sign in to add a comment