New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871429 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Failed to BuildPackages on amd64-generic-goma-canary-chromium-pfq-informational

Project Member Reported by afakhry@chromium.org, Aug 6

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938918305616287344

Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1156588


chromeos-chrome-70.0.3515.0_alpha-r1: FAILED: obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o 
chromeos-chrome-70.0.3515.0_alpha-r1: /home/chrome-bot/goma/gomacc x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -MMD -MF obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"338452-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCR_SYSROOT_HASH=4e7db513b0faeea8fb410f70c9909e8736f5c0ab -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DUSE_EGL -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGTEST_HAS_TR1_TUPLE=0 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DMESA_EGL_NO_X11_HEADERS -DUNIT_TEST -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libyuv/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/googletest/custom -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/googletest/src/googletest/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/modules/skottie/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -flto=thin -fwhole-program-vtables -m64 -march=x86-64 -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -gsplit-dwarf -ggnu-pubnames -fsanitize=cfi-vcall -fsanitize-blacklist=../../../../../../../home/chrome-bot/chrome_root/src/tools/cfi/blacklist.txt -fsanitize=cfi-derived-cast -fsanitize=cfi-unrelated-cast -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-exceptions -fno-rtti --sysroot=../../../../../../../build/amd64-generic -fvisibility-inlines-hidden -pipe -pipe -pipe -march=x86-64 -msse3 -fno-split-dwarf-inlining -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++  -c ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/jpeg_decode_accelerator_unittest.cc -o obj/media/gpu/jpeg_decode_accelerator_unittest/jpeg_decode_accelerator_unittest.o
chromeos-chrome-70.0.3515.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/media/gpu/jpeg_decode_accelerator_unittest.cc:845:3: error: use of undeclared identifier 'mojo'
chromeos-chrome-70.0.3515.0_alpha-r1:   mojo::core::Init();
chromeos-chrome-70.0.3515.0_alpha-r1:   ^
chromeos-chrome-70.0.3515.0_alpha-r1: 1 error generated.
chromeos-chrome-70.0.3515.0_alpha-r1: 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccc9e5db90f1b6fabfe29b42f80a9f397650267

commit 5ccc9e5db90f1b6fabfe29b42f80a9f397650267
Author: Ahmed Fakhry <afakhry@chromium.org>
Date: Mon Aug 06 20:32:36 2018

Revert "media/gpu: add mojo initialization to unittests."

This reverts commit e4378cb927e3b673ac49dd9c0272b88b58027d2d.

Reason for revert: breaks BuildPackages on amd64-generic-goma-canary-chromium-pfq-informational

BUG:  chromium:871429 

Original change's description:
> media/gpu: add mojo initialization to unittests.
> 
> Future changes to shared memory introduce an implicit dependency on
> mojo, which must be initialized in unittests.
> 
> Bug: 849207
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I13de882b7f995ac33385d2f6d5f49b5ac44bb2c4
> Reviewed-on: https://chromium-review.googlesource.com/1156588
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Matthew Cary <mattcary@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580922}

TBR=posciak@chromium.org,mcasas@chromium.org,sandersd@chromium.org,mattcary@chromium.org

Change-Id: Iaa263cfca7e99b36c609db6b4a81dbd56d1a9be3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849207
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1164182
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580973}
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/BUILD.gn
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/jpeg_encode_accelerator_unittest.cc
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/vaapi/BUILD.gn
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/vaapi/vaapi_jpeg_decoder_unittest.cc
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/5ccc9e5db90f1b6fabfe29b42f80a9f397650267/media/gpu/video_encode_accelerator_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment