New issue
Advanced search Search tips

Issue 871422 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Make sure alert-icon color matches the close button icon color

Project Member Reported by kylixrd@chromium.org, Aug 6

Issue description

Based on https://crrev.com/c/1162664, the alert icon may not be the same color as the close (x) icon. This could lead to inadequate contrast.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86

commit 58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Aug 08 18:51:21 2018

Make sure the alert-icon color matches the close button icon color.

Bug:  871422 
Change-Id: I76e5faebaa2f2f338bbb27bfaefe097f9006474a
Reviewed-on: https://chromium-review.googlesource.com/1165268
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581642}
[modify] https://crrev.com/58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86/chrome/browser/ui/views/tabs/tab.h

Status: Fixed (was: Assigned)
Labels: Merge-Request-69
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 15

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Tested on canary.  Justification is twofold: want this to resolve a branch compile failure, and this fixes alert icon contrast just like  bug 856492  fixes close button contrast.
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #5 and per offline chat with  pkasting@.  
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a29af28f9621138b6f0c47a9bf9adbf12b9703

commit 75a29af28f9621138b6f0c47a9bf9adbf12b9703
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Aug 15 17:42:57 2018

Make sure the alert-icon color matches the close button icon color.

(cherry picked from commit 58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86)

Bug:  871422 
Change-Id: I76e5faebaa2f2f338bbb27bfaefe097f9006474a
Reviewed-on: https://chromium-review.googlesource.com/1165268
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581642}
Reviewed-on: https://chromium-review.googlesource.com/1176162
Cr-Commit-Position: refs/branch-heads/3497@{#645}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/75a29af28f9621138b6f0c47a9bf9adbf12b9703/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/75a29af28f9621138b6f0c47a9bf9adbf12b9703/chrome/browser/ui/views/tabs/tab.h

Sign in to add a comment