New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871416 link

Starred by 2 users
Status: Fixed
Owner:
hu...@vewd.com
Closed: Sep 4
Cc:
bsheedy@chromium.org
█ junho092...@lge.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocked on:
issue 803086
Blocking:
issue 770147



Sign in to add a comment

fast/spatial-navigation/snav-stay-in-overflow-div.html failing on linux and win

Project Member Reported by kbr@chromium.org, Aug 6 
Seen here:

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/157716

Layout test results:

https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/157716/layout-test-results/results.html

Text diff:

--- /b/s/w/ioROqAc0/layout-test-results/fast/spatial-navigation/snav-stay-in-overflow-div-expected.txt
+++ /b/s/w/ioROqAc0/layout-test-results/fast/spatial-navigation/snav-stay-in-overflow-div-actual.txt
@@ -5,9 +5,9 @@
 
 TEST COMPLETE
 PASS gFocusedDocument.activeElement.getAttribute("id") is "a"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be b. Was a.
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be c. Was b.
 PASS gFocusedDocument.activeElement.getAttribute("id") is "b"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "c"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "b"
-PASS gFocusedDocument.activeElement.getAttribute("id") is "b"
+FAIL gFocusedDocument.activeElement.getAttribute("id") should be b. Was a.
 PASS gFocusedDocument.activeElement.getAttribute("id") is "a"

Marking P1 because this is blocking the CQ. This blocked an entirely unrelated CL from landing.

Comment 2 by rakina@chromium.org, Aug 8

Labels: -Sheriff-Chromium
Owner: hu...@vewd.com
Status: Assigned (was: Untriaged)
Failure expectations added in https://chromium-review.googlesource.com/c/chromium/src/+/1166562.

Assigning based on git blame.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/167a1685c3314ac1acf6ee4e759272bca54839b7

commit 167a1685c3314ac1acf6ee4e759272bca54839b7
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Aug 08 04:55:28 2018

Disable Layout test flaky fail, timeout, crash

TBR=futhark@chromium.org

Bug:  869470 ,871105,872025, 871416 
Change-Id: Iab76b2330c889d36243f95f3c105f9bba7568819
Reviewed-on: https://chromium-review.googlesource.com/1166564
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581476}
[modify] https://crrev.com/167a1685c3314ac1acf6ee4e759272bca54839b7/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by hu...@vewd.com, Aug 8

Blockedon: 803086
Cc: junho092...@lge.com
Labels: spatial-navigation
Status: Available (was: Assigned)
Summary: fast/spatial-navigation/snav-stay-in-overflow-div.html failing on linux and win (was: fast/spatial-navigation/snav-stay-in-overflow-div.html failing on linux_chromium_rel_ng)
If it doesn't fail on Mac, can we keep it running on the Mac bots? Otherwise snav-stay-in-overflow-div.html won't have any automated testing at all.

When I loop this test on my Linux workstation, I see it being flaky as well.

I hope that https://chromium-review.googlesource.com/c/chromium/src/+/998193 will fix the flakiness.

Comment 5 by hu...@vewd.com, Sep 4

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1cdbbb544c358e70f7475dac02ee23f1897dfd3

commit a1cdbbb544c358e70f7475dac02ee23f1897dfd3
Author: Hugo Holgersson <hugoh@vewd.com>
Date: Tue Sep 04 11:59:18 2018

Snav: Make snav-stay-in-overflow-div.html use snav-testharness.js

This fixes a flakiness that has been haunting this
test for a while. It used to flake ~ 4/100 times:

$ python third_party/WebKit/Tools/Scripts/run-webkit-tests
   --repeat-each=100 -t Release
   LayoutTests/fast/spatial-navigation/snav-stay-in-overflow-div.html

Now, even 1000 runs pass.

snav-testharness.js does not use requestAnimationFrame().
The old helper, spatial-navigation-utils.js, did.
Different rAF-timings probably caused the flakiness.

Bug: 803086,  871416 
Change-Id: Idbf0bfb544236ba1a77986c7d62200b2e17d6884
Reviewed-on: https://chromium-review.googlesource.com/1185188
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588491}
[modify] https://crrev.com/a1cdbbb544c358e70f7475dac02ee23f1897dfd3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/b9916fe70686f0bec51f442265120949ae2281ed/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-stay-in-overflow-div-expected.txt
[modify] https://crrev.com/a1cdbbb544c358e70f7475dac02ee23f1897dfd3/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-stay-in-overflow-div.html

Comment 8 Deleted

Comment 9 Deleted

►

Sign in to add a comment