Show Powerwash button if fatal error occurs during demo mode setup |
|||||||
Issue descriptionThe Demo Mode setup screen should show the right error message when a fatal error occurs that causes the device to require a Powerwash. It should also: * disable the back button * hide the OK button * add a "Restart and Powerwash" button, like the OOBE error screen
,
Aug 10
part of this (showing the error message) was started in this CL which I can take over: https://chromium-review.googlesource.com/c/chromium/src/+/1123316
,
Sep 19
,
Sep 26
,
Sep 26
,
Oct 24
=> wzang
,
Oct 30
Which errors are considered "fatal errors that require a Powerwash" as opposed to "other errors that allow users to try again"?
,
Oct 30
We got rid of "fatal" and replaced it with RecoveryMethod::kPowerwash -- so when a DemoSetupError has a recovery_method_ of kPowerwash, we should show the "Restart and Powerwash" button. Generally these are errors where the device is partially enrolled, ie the TPM is locked, so we can't proceed with any sort of device setup without a powerwash.
,
Oct 30
The DemoSetupError::RecoveryMethod should be used for that. https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h?rcl=84a6a5f0b7244e679579c6e15957b016e6407dee&l=112 Note: We could consider showing 'Reboot' button for RecoveryMethod::kReboot in the future.
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/919287d0a1eda09af61b4115352269a1d256617b commit 919287d0a1eda09af61b4115352269a1d256617b Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Nov 05 05:44:34 2018 cros: Show Powerwash button in case of a fatal demo setup error Bug: 871412 Change-Id: I5bf054ed6ef4c927253fbad4fe09ec674cc58d39 Reviewed-on: https://chromium-review.googlesource.com/c/1310559 Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#605256} [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/chromeos/login/screens/demo_setup_screen.cc [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/resources/chromeos/login/demo_setup.html [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/resources/chromeos/login/demo_setup.js [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/resources/chromeos/login/oobe_buttons.html [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js [modify] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
,
Nov 7
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by michae...@chromium.org
, Aug 10Owner: mukai@chromium.org
Status: Assigned (was: Started)