New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871411 link

Starred by 2 users
Status: Verified
Owner:
manojgupta@chromium.org
Closed: Aug 7
Cc:
█ yunlian@chromium.org
benchan@chromium.org
mnissler@chromium.org
█ rcui@chromium.org
manojgupta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

Failure to build crash-reporter core_collector on betty-asan builder

Project Member Reported by afakhry@chromium.org, Aug 6 
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938931530008102688

Failed to link: undefined symbol: __asan_option_detect_stack_use_after_return

vapier@ could you please triage?

crash-reporter-0.0.1-r2823: [48/51] LINK crash_reporter_test
crash-reporter-0.0.1-r2823: [48/51] LINK crash_reporter
crash-reporter-0.0.1-r2823: [49/51] LINK core_collector
crash-reporter-0.0.1-r2823: [50/51] LINK crash_reporter
crash-reporter-0.0.1-r2823: [51/51] LINK crash_reporter_test
crash-reporter-0.0.1-r2823: /build/betty/tmp/portage/chromeos-base/crash-reporter-0.0.1-r2823/work/crash-reporter-0.0.1/common-mk/platform2.py --libdir=/usr/lib --use_flags=abi_x86_64 amd64 cheets cros-debug cros_i686 direncryption elibc_glibc kernel_linux test userland_GNU --jobs=32 --action=compile --cache_dir=/usr/i686-pc-linux-gnu/var/cache/portage/chromeos-base/crash-reporter --cache_dir=/build/betty/var/cache/portage/chromeos-base/crash-reporter/i686 core_collector
crash-reporter-0.0.1-r2823: 11:30:41: INFO: RunCommand: ninja -C /build/betty/var/cache/portage/chromeos-base/crash-reporter/i686/out/Default -j 32 core_collector
crash-reporter-0.0.1-r2823: ninja: Entering directory `/build/betty/var/cache/portage/chromeos-base/crash-reporter/i686/out/Default'
crash-reporter-0.0.1-r2823: 
crash-reporter-0.0.1-r2823: [0/3] CXX obj/crash-reporter/core-collector/core_collector.coredump_writer.o
crash-reporter-0.0.1-r2823: [0/3] CXX obj/crash-reporter/core-collector/core_collector.core_collector.o
crash-reporter-0.0.1-r2823: [1/3] CXX obj/crash-reporter/core-collector/core_collector.coredump_writer.o
crash-reporter-0.0.1-r2823: [2/3] CXX obj/crash-reporter/core-collector/core_collector.core_collector.o
crash-reporter-0.0.1-r2823: [2/3] LINK core_collector
crash-reporter-0.0.1-r2823: [3/3] LINK core_collector
crash-reporter-0.0.1-r2823: >>> Source compiled.
crash-reporter-0.0.1-r2823: >>> Test phase: chromeos-base/crash-reporter-0.0.1-r2823
crash-reporter-0.0.1-r2823: /build/betty/tmp/portage/chromeos-base/crash-reporter-0.0.1-r2823/work/crash-reporter-0.0.1/common-mk/platform2_test.py --action=pre_test --sysroot=/build/betty -- 
crash-reporter-0.0.1-r2823: ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
crash-reporter-0.0.1-r2823: /build/betty/tmp/portage/chromeos-base/crash-reporter-0.0.1-r2823/work/crash-reporter-0.0.1/common-mk/platform2_test.py --action=run --sysroot=/build/betty -- /build/betty/var/cache/portage/chromeos-base/crash-reporter/out/Default/crash_reporter_test
crash-reporter-0.0.1-r2823: ERROR: ld.so: object 'libsandbox.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
crash-reporter-0.0.1-r2823: chroot: /build/betty
crash-reporter-0.0.1-r2823: cwd: /tmp/portage/chromeos-base/crash-reporter-0.0.1-r2823/work/crash-reporter-0.0.1/crash-reporter
crash-reporter-0.0.1-r2823: cmd: {/var/cache/portage/chromeos-base/crash-reporter/out/Default/crash_reporter_test} '/var/cache/portage/chromeos-base/crash-reporter/out/Default/crash_reporter_test'
crash-reporter-0.0.1-r2823: /var/cache/portage/chromeos-base/crash-reporter/out/Default/crash_reporter_test: symbol lookup error: /usr/lib64/libbase-core-395517.so: undefined symbol: __asan_option_detect_stack_use_after_return

Comment 1 by vapier@chromium.org, Aug 6

Cc: yunlian@chromium.org manojgupta@chromium.org
Components: Tools>ChromeOS-Toolchain
Labels: -Restrict-View-Google
odd ... shouldn't have changed here

my expectation is that libbase-core-395517.so was built with USE=asan and whatever asan libs it used are linked and provide this symbol.  i'm not familiar with the asan internal symbols.

Comment 2 by manojgupta@chromium.org, Aug 6 

crash-reporter asan flags was masked from asan builds (because of 32-bit builds I think)
https://cs.corp.google.com/chromeos_internal/src/private-overlays/overlay-betty-private/profiles/asan/package.use.mask?l=6

I think, we should stop masking the asan flag but fix crash-reporter build system to disable sanitizers in 32-bit builds.

Comment 3 by manojgupta@chromium.org, Aug 6

Owner: manojgupta@chromium.org

Comment 4 by vapier@chromium.org, Aug 6 

thanks for chasing this down
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-betty-private/+/8d1bfdd56cb296001e7d37e731e641223aa8cfa7

commit 8d1bfdd56cb296001e7d37e731e641223aa8cfa7
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Aug 07 08:50:27 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f3a3e97ff473058c8df7c5ee89ebbf310a296ba7

commit f3a3e97ff473058c8df7c5ee89ebbf310a296ba7
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Aug 07 08:50:27 2018

cros-i686: Fix asan use in 32-bit builds.

Address sanitizer can't work for 32-builds since
they need to built statically.

Therefore, disable sanitizers and call platform_configure
directly so that it doesn't add any unsupported flags.

CQ-DEPEND=CL:1164250
BUG= chromium:871411 
TEST=crash-reporter builds on betty.
TEST=asan related symbol errors are gone.

Change-Id: I1933b1aec2b4b9aa48a3e2793d8c937db06633f7
Reviewed-on: https://chromium-review.googlesource.com/1164249
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f3a3e97ff473058c8df7c5ee89ebbf310a296ba7/eclass/cros-i686.eclass
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/598ebf7ccc841525a136089878397d5260bb53c8

commit 598ebf7ccc841525a136089878397d5260bb53c8
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Aug 07 08:50:26 2018

crash-reporter: Don't pass "-static" when building.

Address sanitizer doesn't work with "-static".
32-bit builds need static flag but that is taken care of
by cros-i686 eclass update.

CQ-DEPEND=CL:1164249
BUG= chromium:871411 

TEST=crash-reporter builds with/without asan flags.

Change-Id: I6dbec637dc95a12240b98b239ccca8f006b0e1b7
Reviewed-on: https://chromium-review.googlesource.com/1164250
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/598ebf7ccc841525a136089878397d5260bb53c8/crash-reporter/crash-reporter.gyp

Comment 8 by manojgupta@chromium.org, Aug 7

Status: Verified (was: Assigned)
Unit tests passed today: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938840932943986528

VM Tests are failing but they also fail on amd64-generic-asan. I have opened  BUG chromium:871780  for that.
►

Sign in to add a comment