New issue
Advanced search Search tips

Issue 871407 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

Experiment Switching Client Session to GOAWAY on Path Degrading

Project Member Reported by renjietang@chromium.org, Aug 6

Issue description

Add experiment that enables client side to go away when path degrading is detected.





 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5722ccf3852547206c6c95e84fc0a95b4376068

commit a5722ccf3852547206c6c95e84fc0a95b4376068
Author: Renjie <renjietang@chromium.org>
Date: Fri Aug 10 00:18:49 2018

Add experiment of switching the client to GOAWAY when path degrading is detected.

Change-Id: Ia4f0ccf2a9c896d21f299606adfad6904457984f

Bug: crbug.com/871407
Change-Id: Ia4f0ccf2a9c896d21f299606adfad6904457984f
Reviewed-on: https://chromium-review.googlesource.com/1164065
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581973}
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/components/network_session_configurator/browser/network_session_configurator.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/http/http_network_session.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/http/http_network_session.h
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/http/http_proxy_client_socket_wrapper_unittest.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/log/net_log_event_type_list.h
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/bidirectional_stream_quic_impl_unittest.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_chromium_client_session.h
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_chromium_client_session_test.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_http_stream_test.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_proxy_client_socket_unittest.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_stream_factory.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_stream_factory.h
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_stream_factory_fuzzer.cc
[modify] https://crrev.com/a5722ccf3852547206c6c95e84fc0a95b4376068/net/quic/quic_stream_factory_test.cc

Labels: -Type-Launch Type-Feature
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13a57ea631f8b141949b7f8c8b9eda6e9daa3d4e

commit 13a57ea631f8b141949b7f8c8b9eda6e9daa3d4e
Author: Renjie <renjietang@chromium.org>
Date: Fri Aug 17 01:28:41 2018

Add two UMA metrics to track session status when the session go away on path degrading.

Bug: 871407
Change-Id: I7ac4e7370b1aadd2cf9c702a1218abb789f87c29
Reviewed-on: https://chromium-review.googlesource.com/1173507
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583922}
[modify] https://crrev.com/13a57ea631f8b141949b7f8c8b9eda6e9daa3d4e/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/13a57ea631f8b141949b7f8c8b9eda6e9daa3d4e/tools/metrics/histograms/histograms.xml

Sign in to add a comment