Issue metadata
Sign in to add a comment
|
4.1% regression in memory.top_10_mobile at 579541:579592 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 6
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12ca98c8640000
,
Aug 6
,
Aug 7
📍 Found significant differences after each of 3 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12ca98c8640000 Enable use-zoom-for-dsf on Android on M70 by eirage@chromium.org https://chromium.googlesource.com/chromium/src/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0 4.675e+07 → 4.76e+07 (+8.456e+05) Roll skia/third_party/skcms 2925dc93401c..f80f027f8ac9 (1 commits) by skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com https://skia.googlesource.com/skia/+/990ec990a66aab06bfa18aa16a5e3960a4b34118 4.738e+07 → No values Roll src/third_party/skia b303a427c03d..e782f8472f61 (2 commits) by skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com https://chromium.googlesource.com/chromium/src/+/f7521c9ca78d813019917c2a4df1914353dae6ff No values → 4.838e+07 Assigning to sheriff scroggo@chromium.org because "Roll src/third_party/skia b303a427c03d..e782f8472f61 (2 commits)" is a roll. Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 13
The skcms changes (https://skia-review.googlesource.com/c/skcms/+/144482) just add a test build. This leaves bsalomon@'s https://skia-review.googlesource.com/c/skia/+/142814 as the only potential culprit from Skia.
,
Aug 20
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12d59331640000
,
Aug 20
Looking at the pinpoint link it appears that https://chromium.googlesource.com/chromium/src/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0 is a more likely candidate. I doubt that my change would increase memory usage. Even if it somehow did we'd see it across the board (many tests on many OSes). I kicked off another pinpoint on one test to try to confirm this (comment #6).
,
Aug 20
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12d59331640000 Enable use-zoom-for-dsf on Android on M70 by eirage@chromium.org https://chromium.googlesource.com/chromium/src/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0 4.677e+07 → 4.84e+07 (+1.63e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 20
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 6