New issue
Advanced search Search tips

Issue 871392 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[WPT import] Add "NOAUTOREVERT=true" to the description of import CLs

Project Member Reported by robertma@chromium.org, Aug 6

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1159331#message-138aed03c568c5c41b3fa273f9464389d65c1fdc

chanli@:
Hello, I noticed that in this CL's description, it's mentioned that this CL should not be reverted when build failed because of it. If you don't want Findit to even create a revert for such CLs, you could add 'NOAUTOREVERT=true' to CL description (example: https://chromium-review.googlesource.com/c/chromium/src/+/744731). Thanks.

 
Components: Blink>Infra>Ecosystem
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84877f78631b84613709e2411b6a2051a2781f0

commit c84877f78631b84613709e2411b6a2051a2781f0
Author: Robert Ma <robertma@chromium.org>
Date: Tue Aug 07 19:32:41 2018

[blinkpy] Add NOAUTOREVERT to WPT import CLs

Prevent FindIt from auto-reverting import CLs.

Bug:  871392 
Change-Id: If4fb4abfcbf0e1e7bf95b8272701031ccb96ee38
Reviewed-on: https://chromium-review.googlesource.com/1164030
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581306}
[modify] https://crrev.com/c84877f78631b84613709e2411b6a2051a2781f0/third_party/blink/tools/blinkpy/w3c/test_importer.py
[modify] https://crrev.com/c84877f78631b84613709e2411b6a2051a2781f0/third_party/blink/tools/blinkpy/w3c/test_importer_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment