New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871351 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Move "Connected Devices" settings section

Project Member Reported by khorimoto@chromium.org, Aug 6

Issue description

Order of sections in Chrome OS settings should be Network, Bluetooth, Connected devices (in that order).
 
Labels: Pri-2
Owner: jordynass@chromium.org
Status: Assigned (was: Available)
That's different from the mocks; was it changed?
Yes; this change was requested by Shiba.
Issue 878647 has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21800a000c64d587309eb0fe408df8330a0eb5e9

commit 21800a000c64d587309eb0fe408df8330a0eb5e9
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Sep 05 21:05:32 2018

[CrOS MultiDevice] Move Settings UI main page below Bluetooth

The new mocks switch the Settings UI page order near the MultiDevice
(a.k.a. Connected Devices) sections from

Network
Connected devices
Bluetooth

to

Network
Bluetooth
Connected devices

See the new order in this screenshot of this CL deployed:
https://screenshot.googleplex.com/TJuzLmqHNsL

Bug:  871351 
Change-Id: Iba4016a6ad9b0954f2d5b467aab17a293bd0102e
Reviewed-on: https://chromium-review.googlesource.com/1205501
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588998}
[modify] https://crrev.com/21800a000c64d587309eb0fe408df8330a0eb5e9/chrome/browser/resources/settings/basic_page/basic_page.html

Labels: -M-70
Status: Fixed (was: Assigned)
Labels: M-70
Status: Started (was: Fixed)
Labels: -Restrict-View-Google
Let's move forward with this request per Shiba's guidance:

>Network section
>Bluetooth section
>Connected devices section

On Android, Bluetooth is a subset of Connected devices, which we'll align with in a future release, likely when we launch Fast Pair support. In the meantime, I agree with Shiba that it makes sense for Bluetooth to immediately follow the Network section.
Labels: Merge-Request-70
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 8

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126cbdf21a5611e76b9273c121a98ac66cb0744a

commit 126cbdf21a5611e76b9273c121a98ac66cb0744a
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Sat Sep 08 01:50:48 2018

[CrOS MultiDevice] Move Settings UI main page below Bluetooth

The new mocks switch the Settings UI page order near the MultiDevice
(a.k.a. Connected Devices) sections from

Network
Connected devices
Bluetooth

to

Network
Bluetooth
Connected devices

See the new order in this screenshot of this CL deployed:
https://screenshot.googleplex.com/TJuzLmqHNsL

Bug:  871351 
Change-Id: Iba4016a6ad9b0954f2d5b467aab17a293bd0102e
Reviewed-on: https://chromium-review.googlesource.com/1205501
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588998}(cherry picked from commit 21800a000c64d587309eb0fe408df8330a0eb5e9)
Reviewed-on: https://chromium-review.googlesource.com/1214685
Cr-Commit-Position: refs/branch-heads/3538@{#182}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/126cbdf21a5611e76b9273c121a98ac66cb0744a/chrome/browser/resources/settings/basic_page/basic_page.html

Status: Fixed (was: Started)

Sign in to add a comment