Move "Connected Devices" settings section |
|||||||||
Issue descriptionOrder of sections in Chrome OS settings should be Network, Bluetooth, Connected devices (in that order).
,
Aug 22
,
Aug 25
That's different from the mocks; was it changed?
,
Aug 25
Yes; this change was requested by Shiba.
,
Aug 29
Issue 878647 has been merged into this issue.
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21800a000c64d587309eb0fe408df8330a0eb5e9 commit 21800a000c64d587309eb0fe408df8330a0eb5e9 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Wed Sep 05 21:05:32 2018 [CrOS MultiDevice] Move Settings UI main page below Bluetooth The new mocks switch the Settings UI page order near the MultiDevice (a.k.a. Connected Devices) sections from Network Connected devices Bluetooth to Network Bluetooth Connected devices See the new order in this screenshot of this CL deployed: https://screenshot.googleplex.com/TJuzLmqHNsL Bug: 871351 Change-Id: Iba4016a6ad9b0954f2d5b467aab17a293bd0102e Reviewed-on: https://chromium-review.googlesource.com/1205501 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#588998} [modify] https://crrev.com/21800a000c64d587309eb0fe408df8330a0eb5e9/chrome/browser/resources/settings/basic_page/basic_page.html
,
Sep 5
,
Sep 5
,
Sep 5
,
Sep 6
Let's move forward with this request per Shiba's guidance: >Network section >Bluetooth section >Connected devices section On Android, Bluetooth is a subset of Connected devices, which we'll align with in a future release, likely when we launch Fast Pair support. In the meantime, I agree with Shiba that it makes sense for Bluetooth to immediately follow the Network section.
,
Sep 7
,
Sep 8
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/126cbdf21a5611e76b9273c121a98ac66cb0744a commit 126cbdf21a5611e76b9273c121a98ac66cb0744a Author: Jordy Greenblatt <jordynass@chromium.org> Date: Sat Sep 08 01:50:48 2018 [CrOS MultiDevice] Move Settings UI main page below Bluetooth The new mocks switch the Settings UI page order near the MultiDevice (a.k.a. Connected Devices) sections from Network Connected devices Bluetooth to Network Bluetooth Connected devices See the new order in this screenshot of this CL deployed: https://screenshot.googleplex.com/TJuzLmqHNsL Bug: 871351 Change-Id: Iba4016a6ad9b0954f2d5b467aab17a293bd0102e Reviewed-on: https://chromium-review.googlesource.com/1205501 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588998}(cherry picked from commit 21800a000c64d587309eb0fe408df8330a0eb5e9) Reviewed-on: https://chromium-review.googlesource.com/1214685 Cr-Commit-Position: refs/branch-heads/3538@{#182} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/126cbdf21a5611e76b9273c121a98ac66cb0744a/chrome/browser/resources/settings/basic_page/basic_page.html
,
Sep 8
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jlklein@chromium.org
, Aug 16