New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871347 link

Starred by 9 users

Issue metadata

Status: Duplicate
Merged: issue 893860
Owner:
Closed: Oct 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 737777



Sign in to add a comment

54.4% regression in rendering.mobile at 579514:579583

Project Member Reported by chiniforooshan@chromium.org, Aug 6

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=871347

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4ca56edef89679e4445fede912f00b80197cd8d2ecd2d406cf26183839facbda


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf
Cc: eirage@chromium.org
Owner: eirage@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1489ad58640000

Enable use-zoom-for-dsf on Android on M70 by eirage@chromium.org
https://chromium.googlesource.com/chromium/src/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0
60.05 → 26.09 (-33.95)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: ericrk@chromium.org
 Issue 871935  has been merged into this issue.
Cc: toyoshim@chromium.org
 Issue 872604  has been merged into this issue.
Cc: mustaq@google.com olivierli@chromium.org
 Issue 871304  has been merged into this issue.
Cc: kouhei@chromium.org
 Issue 874418  has been merged into this issue.
Cc: tdres...@chromium.org
 Issue 875423  has been merged into this issue.
 Issue 874871  has been merged into this issue.
 Issue 875359  has been merged into this issue.
Labels: -Pri-2 ReleaseBlock-Beta OS-Android Pri-1
eirage@ this looks like a pretty large regression.  Could you please confirm if it's expected?  Marking P1, RB-B for now.

Other related graphs: https://chromeperf.appspot.com/report?sid=32cc1b277af84c8bc64e2c3b097b8e6d48c8e5e687d6be0f8ed2e9546145073b
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/145fae51640000

Enable use-zoom-for-dsf on Android on M70 by eirage@chromium.org
https://chromium.googlesource.com/chromium/src/+/d0b8bbd2dbf9c06dcbbd01a4b1285cf7a1bc2ba0
17.75 → 23.96 (+6.211)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Labels: -ReleaseBlock-Beta
The flag is off, removing RB-B
Labels: -Performance-Sheriff
Cc: crouleau@chromium.org tmathmeyer@google.com
 Issue 870168  has been merged into this issue.
Blocking: 737777
Cc: -crouleau@chromium.org
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bdc415d08a3e7256cda5b3504a435339454c407

commit 9bdc415d08a3e7256cda5b3504a435339454c407
Author: Ella Ge <eirage@chromium.org>
Date: Fri Sep 21 16:40:57 2018

solid color quads workaround for use-zoom-for-dsf

solid color quads used scale = 1 for non-mask layer, so when
use-zoom-for-dsf is enabled, it generates a lot more solid color
quads, which causes a bunch of rendering performance regression.

This CL makes the scale = 1 / dsf when use-zoom-for-dsf is enable,
so we generate same amount solid color quads as before.
This should not break solid color quad as it doesn't count dsf before.

Bug:  871347 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7f30ebf51fbd9bfe8800aa34f228b98985358c39
Reviewed-on: https://chromium-review.googlesource.com/1234362
Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Xianda Sun <sunxd@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593221}
[modify] https://crrev.com/9bdc415d08a3e7256cda5b3504a435339454c407/cc/layers/picture_layer_impl.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d5990bc6b25d7b7ce711b035147030e778879a

commit d7d5990bc6b25d7b7ce711b035147030e778879a
Author: Ella Ge <eirage@chromium.org>
Date: Fri Oct 05 23:51:35 2018

Revert "solid color quads workaround for use-zoom-for-dsf"

This reverts commit 9bdc415d08a3e7256cda5b3504a435339454c407.

Reason for revert:
This workaround is causing issue such as: crbug/888440 and
the also black patch mentioned in crbug/879766#50

Original change's description:
> solid color quads workaround for use-zoom-for-dsf
>
> solid color quads used scale = 1 for non-mask layer, so when
> use-zoom-for-dsf is enabled, it generates a lot more solid color
> quads, which causes a bunch of rendering performance regression.
>
> This CL makes the scale = 1 / dsf when use-zoom-for-dsf is enable,
> so we generate same amount solid color quads as before.
> This should not break solid color quad as it doesn't count dsf before.
>
> Bug:  871347 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I7f30ebf51fbd9bfe8800aa34f228b98985358c39
> Reviewed-on: https://chromium-review.googlesource.com/1234362
> Reviewed-by: weiliangc <weiliangc@chromium.org>
> Reviewed-by: Xianda Sun <sunxd@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593221}

TBR=weiliangc@chromium.org,sunxd@chromium.org,eirage@chromium.org, kbr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  871347 , 888440
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaac40f237a97cc57cb91905d73b65ccb3afd5d6f
Reviewed-on: https://chromium-review.googlesource.com/c/1264740
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597373}
[modify] https://crrev.com/d7d5990bc6b25d7b7ce711b035147030e778879a/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/d7d5990bc6b25d7b7ce711b035147030e778879a/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/d7d5990bc6b25d7b7ce711b035147030e778879a/content/test/gpu/gpu_tests/pixel_test_pages.py

Mergedinto: 893860
Status: Duplicate (was: Assigned)

Sign in to add a comment