[MdRefresh] Omnibox Textinput Field next to the divider of the SearchEngine Chip/Label is too far right |
||||||||||||
Issue descriptionChrome Version: Version 70.0.3512.0 Canary OS: macOS 10.13.6, but probably OS=All What steps will reproduce the problem? (0) Be sure that the Omnibox textinput "jog" is enabled (1) type youtube.com into the Omnibox (2) press TAB-key. so that the SearchEngine Search appears (3) take a look at the start point of the TextInput field What is the expected result? The divider should be nicely centered. What happens instead? A large space between divider and Textinput is to see. The larger gap is to see when the textinput "jog" is enabled. If it is deactivated, a smaller gap appears (which is also not centered, but it looks more polished.) Screenshots are attached. Thanks Mehmet
,
Aug 6
(fyi: A related report to center the divider is issue 848421.)
,
Aug 7
Okay, it seems that the textinput jog is also present for the SearchEngine Search. Therefore the large gap is too see. Maybe the jog should be disabled for the SearchEngine Search? Here is a screencast. Thanks :)
,
Aug 7
I think this is a one line fix. Let me give this a shot and if it's a quick fix we might even be able to merge it.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3836b7bb777e308be37c3123219124f911c5109a commit 3836b7bb777e308be37c3123219124f911c5109a Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 08 16:40:25 2018 Omnibox UI Refresh: Fix unwanted textfield jog with a selected keyword When there is a selected keyword label, i.e. "Search Google", we already indent the selected keyword label to align with the suggestions text. Further jogging over the textfield just moves the text for no apparent purpose. This CL fixes that. Bug: 871265 Change-Id: I956577e741359efa8a3293ef160de39f4c2c952c Reviewed-on: https://chromium-review.googlesource.com/1166299 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581595} [modify] https://crrev.com/3836b7bb777e308be37c3123219124f911c5109a/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Aug 9
Tried to reproduce the issue on Mac OS 10.13.3 and Windows 10 on the reported version 70.0.3512.0 and unable to reproduce the issue by following the below steps. 1. Launched Chrome and enabled #omnibox-ui-jog-textfield-on-popup flag and set #top-chrome-md to Refresh. 2. In omnibox, typed youtube.com and on hitting the tab key, the SearchEngine Search is not appearing. Attached is the screen cast for reference. tommycli@ Request you to check and confirm if anything is missed from our end in verifying the issue. Thanks..
,
Aug 9
susan.boorgula@ I think you also have to enable MacViews, so that the MdRefresh Theme is active and youtube.com has to be defined as a SearchEngine. It seems that Canary hasn't been updated yet, so the CL from c#5 can't be tested at the moment in Canary. But I checked it in Chromium Trunk {#581596}, which includes the CL and it works for me with enabled Textjog. Thanks :) Attached a screencast.
,
Aug 9
,
Aug 9
,
Aug 9
I just verified this on Canary. Requesting a merge. Re c#6, you should be able to reproduce by enabling only this flag: chrome://flags/#upcoming-ui-features
,
Aug 9
CL is a one-liner effectively, and effects are isolated. I think it's a low risk for both merge conflicts and technical risk.
,
Aug 9
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 9
Approving merge to M69 branch 3497 based on comments #10 and #11. Please merge ASAP. Thank you.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cec0ddcd68e7ef177434c9cd4fd0b537c6514147 commit cec0ddcd68e7ef177434c9cd4fd0b537c6514147 Author: Tommy C. Li <tommycli@chromium.org> Date: Thu Aug 09 22:22:35 2018 Omnibox UI Refresh: Fix unwanted textfield jog with a selected keyword When there is a selected keyword label, i.e. "Search Google", we already indent the selected keyword label to align with the suggestions text. Further jogging over the textfield just moves the text for no apparent purpose. This CL fixes that. Bug: 871265 Change-Id: I956577e741359efa8a3293ef160de39f4c2c952c Reviewed-on: https://chromium-review.googlesource.com/1166299 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581595}(cherry picked from commit 3836b7bb777e308be37c3123219124f911c5109a) Reviewed-on: https://chromium-review.googlesource.com/1169406 Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#523} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/cec0ddcd68e7ef177434c9cd4fd0b537c6514147/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Aug 9
Thanks for merge reminder govind!
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh .
,
Aug 16
Retried to reproduce the issue on Windows 10 on the reported version 70.0.3512.0 as per comment #10 and still unable to view the SearchEngine Search on hitting the tab key after typing youtube.com in omnibox. Attached is the screen cast for reference. tommycli@ - Could you please check and let us know if any thing missed from our end in verifying the fix. Thanks...!!
,
Aug 16
re c#17, I think you need to have visited youtube.com first in order to use youtube.com as the test case. Can you try using yahoo.com instead? That one is built-in.
,
Aug 16
Thank you Tommy, Verified the fix on latest Chrome 69.0.3497.42 on Windows, Mac and Linux with steps below : Pre-requisite : Enabled #upcoming-ui-features from chrome://flags Steps to reproduce : 1. Launch Chrome and enable above specified flag from Chrome://flags 2. With in same tab type in youtube.com or yahoo.com and Press Tab-Key, so that the SearchEngine Search appears 3. take a look at the start point of the TextInput field Observed behavior : The space isn't that much when compared to before the fix. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by meh...@chromium.org
, Aug 6