Is it too late to fix the bug in 69? The fix should not be hard.

When I try to reproduce, I don't have the Print and RequestDesktopSite actions.
The other actions are here.

Except FIP, they are all working as intended.

Showing "Read Later" for Offline Page feels odd, given that the article is already in the reading list.

I don't see "Desktop User Agent" anymore (maybe it was not there in the first place), but I do see Print, which does not work and opens a blank printing page (attached screenshot).

Deleted: IMG_6585.PNG 170 KB

	IMG_6585.PNG 170 KB View Download

This isn't connected to UI Refresh, is it? 

This is mostly connected to UI Refresh. Share menu in M68 does not have FIP, Desktop User Agent and Print for Offline Version of the article. 

"Read Later" action in present in M68.

eugenebut@: I don't have the "Print" option (tested on multiple pages, including articles from the nytimes if you want to confirm). Do you get it on every offline page? Also, are you sure it is the Chrome Print action and not from another app?

Showing ReadLater might be weird, but I think we decided to keep it when we were creating the feature (we can revisit this if you think it is worth it).

Removed references to "Read Later" from the bug description. Seems like we left the action intentionally, so the issue is orthogonal to this bug.

I see Print on every offline page including articles from New York Times. Print action is in the second row (I'm not sure if other apps can put their actions in that second row).

I tried 70.0.3521.0 on iPhone SE iOS 11.2.6. I wasn't able to see the print option.
Other apps can add actions to the second row (they shouldn't but it is possible).

Can we have some help from the test team to check if it is visible? Same for the "Request Desktop Site" (I still don't see it).

When viewing Offline Articles, I can see "Read Later" and "Find in Page" all the times. Tapping on Find in Page won't perform any action.

As far as Print option, I can see only when the device Region is in UnitedStates. If I change the device region settings to "United Kingdom" then Print option is not displayed for offline articles.

@gambard, can you please try change the settings (Settings.app > General >Language & Region > Region > United States") and see if you can see the Print option in offline articles?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdcdc5ea86db7374d153e8436e388dfbc5fc709b

commit cdcdc5ea86db7374d153e8436e388dfbc5fc709b
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Aug 13 15:41:41 2018

Show FindInPage activity only when it is relevant

The FindInPage activity should only be shown when the FindInPage action
is doing something.
This CL adds a BOOL to know if the page can be searched. It is used to
display the activity or not.

Bug:  871260 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c
Reviewed-on: https://chromium-review.googlesource.com/1172287
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582590}
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/share_to_data.h
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/share_to_data.mm
[modify] https://crrev.com/cdcdc5ea86db7374d153e8436e388dfbc5fc709b/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm

I got it on some phones but not all of them. I have no idea what is different from one phone to the other. Changing the region on the phone doesn't seem to change it.

srikanthg@, are you able to make it appear/disappear based on the region on the same phone?

Actually I was able to do that once before updating the bug. But now I am not seeing the Print option in any of the Regions. Will update once agian if I get any consistent repro steps.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f

commit 036d3ed6c39ab09d0dcbe25829ddd8827f053a1f
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Aug 14 03:51:11 2018

Revert "Show FindInPage activity only when it is relevant"

This reverts commit cdcdc5ea86db7374d153e8436e388dfbc5fc709b.

Reason for revert: ios_chrome_unittests fails.


Original change's description:
> Show FindInPage activity only when it is relevant
> 
> The FindInPage activity should only be shown when the FindInPage action
> is doing something.
> This CL adds a BOOL to know if the page can be searched. It is used to
> display the activity or not.
> 
> Bug:  871260 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c
> Reviewed-on: https://chromium-review.googlesource.com/1172287
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582590}

TBR=pkl@chromium.org,gambard@chromium.org

Change-Id: Ibc4e514b67ef554a4b0fe49841499b10d638c3c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  871260 ,  873718 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1173871
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582826}
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/share_to_data.h
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/share_to_data.mm
[modify] https://crrev.com/036d3ed6c39ab09d0dcbe25829ddd8827f053a1f/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0978be96d0a06f15e2d074a55ac496455d3f8c0d

commit 0978be96d0a06f15e2d074a55ac496455d3f8c0d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 16 15:42:04 2018

Reland "Show FindInPage activity only when it is relevant"

The FindInPage activity should only be shown when the FindInPage action
is doing something.
This CL adds a BOOL to know if the page can be searched. It is used to
display the activity or not.

Bug:  871260 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I35dacc9c1adf1410f1c080af672f9abf2b5ec37f
Reviewed-on: https://chromium-review.googlesource.com/1174114
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583666}
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/share_to_data.h
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/share_to_data.mm
[modify] https://crrev.com/0978be96d0a06f15e2d074a55ac496455d3f8c0d/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm

I will close this bug as we don't have repro steps for the Print issue.
Re-open or create a new bug if the print issue is reappearing.

Verified on 70.0.3529.0 Canary, iPhone X  iOS 11.4.1, iPhone 7 iOS 12.0 beta#9

Sharing options: Read Later, Bookmarks, Find in Page, Request Desktop Site and Print

https://drive.google.com/file/d/1fgCFBzU_5csdNLFLnBLec7rLJEadvn6A/view