Remove -dev files from src.git's infra/global/config |
|||||
Issue descriptionin chromium's infra/config/global, there's bot X.cfg and X-dev.cfg for X in cr-buildbucket, luci-logdog, luci-milo. The -dev file is only used for testing these services, so they should be somewhere else so that people working on chromium don't think they need to keep them up-to-date when they change the non-dev files. See https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/n5Wneg6gcLE
,
Aug 9
Before Chromium used LUCI in production, it was reasonable to keep dev files to do occasional experiments with Chromium data/builders, but now that LUCI is actively used, we shouldn't use Chromium as a sandbox. For such experiments, we should use one of - https://chromium.googlesource.com/infra/experimental/+/infra/config - https://chromium.googlesource.com/infra/infra/+/infra/config I think we should delete -dev files from https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/ Andrii, WDYT?
,
Aug 9
As I wrote in underlying thread, I'm in favor. luci-scheduler isn't in chromium/src. I think neither should be Milo (and i think Milo actually has -dev config in experimental already). For buildbucket - your call :) For logdog - I don't think -dev is even used. So, overall: LGTM.
,
Aug 13
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8de089e6365be7ece9920c20dc17ad8ee3d1572e commit 8de089e6365be7ece9920c20dc17ad8ee3d1572e Author: Nodir Turakulov <nodir@google.com> Date: Mon Aug 13 23:00:01 2018 Remove luci -dev config files Remove infra/config/global/*-dev.cfg files. Reasoning: https://crbug.com/871245#c2 R=dpranke@chromium.org, tandrii@chromium.org BUG: 871245 Change-Id: I1792a02c52e648b96ba0c186078bd78cdf63dbdc Reviewed-on: https://chromium-review.googlesource.com/1173430 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582731} [delete] https://crrev.com/762a6a7d62fadf2dacd5d125c984f8ee961ab707/infra/config/global/cr-buildbucket-dev.cfg [delete] https://crrev.com/762a6a7d62fadf2dacd5d125c984f8ee961ab707/infra/config/global/luci-logdog-dev.cfg [delete] https://crrev.com/762a6a7d62fadf2dacd5d125c984f8ee961ab707/infra/config/global/luci-milo-dev.cfg [delete] https://crrev.com/762a6a7d62fadf2dacd5d125c984f8ee961ab707/infra/config/global/luci-scheduler-dev.cfg
,
Aug 13
,
Aug 14
I am partially restoring these in https://chromium-review.googlesource.com/c/chromium/src/+/1173502 for the builders we intentionally want to run on the dev instances (i.e., the bots on chromium.swarm).
,
Aug 14
That's unfortunate. I didn't understand the thinking behind these -dev files. When adding bots, I found an existing similar bot and made all these files look similar for my new bot. It's pretty likely that most non-infra folks adding bots use the same mechanism. Removing these files made adding bots much less confusing imho. Adding them back solely for chromium.swarm (which maruel tells me basically should go away once some bug I can't remember is fixed) is extra unfortunate.
,
Aug 15
maruel and I will have to discuss that, then; I'm not aware of a bug that would allow it to go away.
,
Aug 16
We need a better way of handling staging and rollout of services, and this is something we've been discussing a bit but don't have a good answer for yet. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by estaab@chromium.org
, Aug 7Owner: no...@chromium.org
Status: Assigned (was: Untriaged)