New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871245 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove -dev files from src.git's infra/global/config

Project Member Reported by thakis@chromium.org, Aug 6

Issue description

in chromium's infra/config/global, there's bot X.cfg and X-dev.cfg for X in cr-buildbucket, luci-logdog, luci-milo. The -dev file is only used for testing these services, so they should be somewhere else so that people working on chromium don't think they need to keep them up-to-date when they change the non-dev files.

See https://groups.google.com/a/chromium.org/forum/#!topic/infra-dev/n5Wneg6gcLE
 
Cc: tandrii@chromium.org
Owner: no...@chromium.org
Status: Assigned (was: Untriaged)
Nodir, do you know where we should move the dev files?
Before Chromium used LUCI in production, it was reasonable to keep dev files to do occasional experiments with Chromium data/builders, but now that LUCI is actively used, we shouldn't use Chromium as a sandbox. For such experiments, we should use one of
- https://chromium.googlesource.com/infra/experimental/+/infra/config
- https://chromium.googlesource.com/infra/infra/+/infra/config

I think we should delete -dev files from https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/

Andrii, WDYT?

As I wrote in underlying thread, I'm in favor.
luci-scheduler isn't in chromium/src.
I think neither should be Milo (and i think Milo actually has -dev config in experimental already).
For buildbucket - your call :)
For logdog - I don't think -dev is even used.

So, overall: LGTM.
Status: Started (was: Assigned)
Status: Fixed (was: Started)
I am partially restoring these in https://chromium-review.googlesource.com/c/chromium/src/+/1173502 for the builders we intentionally want to run on the dev instances (i.e., the bots on chromium.swarm).
Cc: jbudorick@chromium.org mar...@chromium.org
That's unfortunate. I didn't understand the thinking behind these -dev files. When adding bots, I found an existing similar bot and made all these files look similar for my new bot. It's pretty likely that most non-infra folks adding bots use the same mechanism. Removing these files made adding bots much less confusing imho.

Adding them back solely for chromium.swarm (which maruel tells me basically should go away once some bug I can't remember is fixed) is extra unfortunate.
maruel and I will have to discuss that, then; I'm not aware of a bug that would allow it to go away.
Cc: amcrae@chromium.org packrat@chromium.org
We need a better way of handling staging and rollout of services, and this is something we've been discussing a bit but don't have a good answer for yet.


Sign in to add a comment