New issue
Advanced search Search tips

Issue 871244 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Accessory sheet pushed up by keyboard on second field tap

Project Member Reported by ioanap@chromium.org, Aug 6

Issue description

OS: Android

What steps will reproduce the problem?
(1) Navigate to a sign-in form.
(2) Tap on the password field, then on the key icon.
(3) With the accessory sheet open, tap on the field again.

What is the expected result?
Unclear - maybe close the accessory sheet?

What happens instead?
The keyboard opens, pushing the accessory sheet up and resulting in a completely covered screen.
 
Description: Show this description
Closing the accessory sheet might not be ideal, but afaik, we cannot really suppress the keyboard here, so I am going to close it for now...
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc03e4276c67babcac8e04e61ad3c59080d21988

commit cc03e4276c67babcac8e04e61ad3c59080d21988
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Aug 09 07:31:57 2018

[Android] Close accessory sheet when refocusing same field

When tapping an input field, the keyboard will always come up.
Because this cannot be suppressed easily, the accessory sheet will close
to not clutter the screen.

Bug:  871244 
Change-Id: I823225a05601ae4a1eb92a08767729fdfd94dac7
Reviewed-on: https://chromium-review.googlesource.com/1167512
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581817}
[modify] https://crrev.com/cc03e4276c67babcac8e04e61ad3c59080d21988/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/cc03e4276c67babcac8e04e61ad3c59080d21988/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java

Status: Fixed (was: Started)

Sign in to add a comment