[css-grid] Percentage column and space-between issue |
||
Issue descriptionThis is similar to issue #871230 but I don't know if the root cause is the same so reporting as separated issues so far. If you open the attachment, the size of the first row and the grid container is wrong. The problem happens only with "justify-content: space-between" in this case "space-around" or "space-evenly" work properly.
,
Aug 13
You are probably looking for a change made after 566409 (known good), but no later than 566414 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/447883683661cf3fc7c1296dfa9f379510948ada..4b17e6ae5411e8de94a4fd22c0324bd66639a7b7
,
Aug 13
This is likely the commit causing the regression: https://chromium.googlesource.com/chromium/src/+/0429cc5427bad3ca73d5dbd8731fdfbd563e4b4f
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b5eb052979894d62b0ce5fec17a3b4768546e29 commit 0b5eb052979894d62b0ce5fec17a3b4768546e29 Author: Javier Fernandez <jfernandez@igalia.com> Date: Thu Aug 16 20:47:05 2018 [css-grid] Distribution offset doesn't account for non-spanning items We recenttly changed the track sizing algorithm so that it considers the offsets added by the Content Alignment properties. The change in r566412 introduce intermediate steps in the track sizing algorithm so that inline-axis Content Distribution accounts for the row tracks sizes computed in the next step. However, we were adding the Content Distribution offsets for any column track, but we should do it only for the tracks with spanning items. This error led to the mentioned bugs and this change fixes them. Bug: 871230 , 871242 Change-Id: I8ac789ccacc2e5a51bfafd7820ed08e96a31e58b Reviewed-on: https://chromium-review.googlesource.com/1176803 Reviewed-by: Sergio Villar <svillar@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#583802} [delete] https://crrev.com/951f01300ff05a81ad5256c4a78510f59c1d8fab/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-002-expected.txt [add] https://crrev.com/0b5eb052979894d62b0ce5fec17a3b4768546e29/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-003.html [add] https://crrev.com/0b5eb052979894d62b0ce5fec17a3b4768546e29/third_party/WebKit/LayoutTests/external/wpt/css/css-grid/layout-algorithm/grid-content-distribution-must-account-for-track-sizing-004.html [modify] https://crrev.com/0b5eb052979894d62b0ce5fec17a3b4768546e29/third_party/blink/renderer/core/layout/grid_track_sizing_algorithm.cc
,
Aug 16
This issue should be FIXED now. |
||
►
Sign in to add a comment |
||
Comment 1 by jfernan...@igalia.com
, Aug 13