New issue
Advanced search Search tips

Issue 871238 link

Starred by 1 user
Status: Fixed
Owner:
zmin@chromium.org
Closed: Aug 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MachineLevelUserCloudPolicyEnrollmentTest issue

Project Member Reported by zmin@chromium.org, Aug 6 
MachineLevelUserCloudPolicyEnrollmentTest has test case for both enrollment succeeded and failed. However, when enrollment failed in the test, Chrome quit in the early stages of launch process. In the case, test body won't be executed thus some verification is not verified.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d495ffe01cac8263b172599e5b3114d08908e41

commit 6d495ffe01cac8263b172599e5b3114d08908e41
Author: Owen Min <zmin@chromium.org>
Date: Mon Aug 06 15:46:42 2018

Fix an issue in MachineLevelUserCloudPolicyBrowserTest

Move the verfication of enrollment failure into teardown because test body
is skipped as Chrome quit during launch.

Also remove the runloop in the test because the enrollment process blocks
Chrome launch process which also blocks the browser test.

Bug:  871238 
Change-Id: Ic886ac50b4c4cc215e2cad33294b43f308e17322
Reviewed-on: https://chromium-review.googlesource.com/1161465
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580882}
[modify] https://crrev.com/6d495ffe01cac8263b172599e5b3114d08908e41/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc

Comment 2 by zmin@chromium.org, Aug 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment