Disabled PasswordsSettingsTestCase.testDuplicatedBlacklistedFormDeletionInDetailView |
||
Issue descriptionThe underlying password store no longer allows adding duplicate blacklisted forms. This test may no longer be valid. Please investigate and either update the test or delete it, if it indeed is no longer useful. Thanks!
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ea9b5ee08b766efcf2ea8188f2444b52db93696 commit 9ea9b5ee08b766efcf2ea8188f2444b52db93696 Author: Gemene Narcis <gemene@google.com> Date: Thu Aug 16 08:38:20 2018 Reland "Prevent adding blacklisted duplicates" This is a reland of 9c6c7b842947b8aab18141088902fe85e1d9dc89 Also, this CL deletes testDuplicatedBlacklistedFormDeletionInDetailView because duplicates are cleaned up in r578318 and this CL doesn't allow Password Store to add new ones. Thus, the test is obsolete. Original change's description: > Prevent adding blacklisted duplicates > > Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. > > Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. > > Bug: 862930 > Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc > Reviewed-on: https://chromium-review.googlesource.com/1151636 > Commit-Queue: Narcis Gemene <gemene@google.com> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580836} Bug: 862930 , 871223 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a66bf412b7b89ba5ad61a7d99faa26e5910ff9d Reviewed-on: https://chromium-review.googlesource.com/1164783 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#583583} [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database.h [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/login_database_unittest.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager_util.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/browser/password_manager_util_unittest.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/common/password_manager_pref_names.cc [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/components/password_manager/core/common/password_manager_pref_names.h [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9ea9b5ee08b766efcf2ea8188f2444b52db93696/tools/metrics/histograms/histograms.xml
,
Aug 20
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 6